wip

Author: silesky

packages/signals/signals-integration-tests/src/tests/signals-vanilla/basic.test.ts

@@ -35,10 +35,7 @@ test('network signals fetch', async () => {
     (el) => el.properties!.data.action === 'response'
   )
   expect(responses).toHaveLength(1)
-  const signalData = responses[0].properties!.data
-  expect(signalData.data).toEqual({ someResponse: 'yep' })
-  expect(signalData.anonymousId).toBe(responses[0].anonymousId)
-  expect(signalData.timestamp).toMatch(isoDateRegEx)
+  expect(responses[0].properties!.data.data).toEqual({ someResponse: 'yep' })
 })
 
 test('network signals xhr', async () => {
@@ -64,8 +61,7 @@ test('network signals xhr', async () => {
   expect(responses[0].properties!.data.page).toEqual(commonSignalData.page)
 })
 
-const isoDateRegEx = /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}Z$/
-test.only('instrumentation signals', async () => {
+test('instrumentation signals', async () => {
   /**
    * Make an analytics.page() call, see if it gets sent to the signals endpoint
    */
@@ -74,20 +70,17 @@ test.only('instrumentation signals', async () => {
     indexPage.waitForSignalsApiFlush(),
   ])
 
+  const isoDateRegEx = /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}\.\d{3}Z$/
   const instrumentationEvents =
     indexPage.signalsAPI.getEvents('instrumentation')
   expect(instrumentationEvents).toHaveLength(1)
   const ev = instrumentationEvents[0]
   expect(ev.event).toBe('Segment Signal Generated')
   expect(ev.type).toBe('track')
   const rawEvent = ev.properties!.data.rawEvent
-  expect(ev.properties!.type).toBe('instrumentation')
-  expect(ev.properties!.timestamp).toMatch(isoDateRegEx)
-  expect(ev.properties!.anonymousId).toBe(ev.anonymousId)
-  expect(ev.properties)
   expect(rawEvent).toMatchObject({
     type: 'page',
-    anonymousId: ev.anonymousId,
+    anonymousId: expect.any(String),
     timestamp: expect.stringMatching(isoDateRegEx),
   })
 })
@@ -130,8 +123,6 @@ test('interaction signals', async () => {
     type: 'track',
     properties: {
       type: 'interaction',
-      anonymousId: interactionSignals[0].anonymousId,
-      timestamp: expect.stringMatching(isoDateRegEx),
       data,
     },
   })
@@ -163,8 +154,6 @@ test('navigation signals', async ({ page }) => {
     const ev = indexPage.signalsAPI.lastEvent('navigation')
     expect(ev.properties).toMatchObject({
       type: 'navigation',
-      anonymousId: ev.anonymousId,
-      timestamp: expect.stringMatching(isoDateRegEx),
       data: {
         action: 'pageLoad',
         url: indexPage.url,
@@ -187,8 +176,6 @@ test('navigation signals', async ({ page }) => {
     const ev = indexPage.signalsAPI.lastEvent('navigation')
     expect(ev.properties).toMatchObject({
       index: expect.any(Number),
-      anonymousId: ev.anonymousId,
-      timestamp: expect.stringMatching(isoDateRegEx),
       type: 'navigation',
       data: {
         action: 'urlChange',

packages/signals/signals-integration-tests/src/tests/signals-vanilla/top-level-metadata.test.ts

@@ -1,9 +1,14 @@
 import { test, expect } from '@playwright/test'
+import { waitForCondition } from '../../helpers/playwright-utils'
 import { IndexPage } from './index-page'
 
 const basicEdgeFn = `
     // this is a process signal function
-    const processSignal = (signal) => {}
+    const processSignal = (signal) => {
+      if (signal.type === 'interaction') {
+        analytics.track('hello', { myAnonId: signal.anonymousId, myTimestamp: signal.timestamp })
+      } 
+    }
 `
 
 let indexPage: IndexPage
@@ -49,4 +54,18 @@ test('Signals should have anonymousId and timestamp at top level', async () => {
       expect(event.properties).toMatchObject(expected)
     })
   })
+
+  const getCreatedEvent = () =>
+    indexPage.trackingAPI
+      .getEvents()
+      .find((el) => el.type === 'track' && el.event === 'hello')
+
+  await waitForCondition(() => !!getCreatedEvent(), {
+    errorMessage: 'No track events found, should have an event',
+  })
+  const event = getCreatedEvent()!
+  expect(event.properties).toEqual({
+    myAnonId: event.anonymousId,
+    myTimestamp: expect.stringMatching(isoDateRegEx),
+  })
 })