wip

Author: silesky

packages/signals/signals/src/core/emitter/index.ts

@@ -8,19 +8,29 @@ export interface EmitSignal {
 
 export class SignalEmitter implements EmitSignal {
   private emitter = new Emitter<{ add: [Signal] }>()
+  private listeners = new Set<(signal: Signal) => void>()
 
   emit(signal: Signal) {
     logger.debug('New signal:', signal.type, signal.data)
     this.emitter.emit('add', signal)
   }
 
-  subscribe(broadcaster: (signal: Signal) => void) {
-    logger.debug('subscribed')
-    this.emitter.on('add', broadcaster)
+  subscribe(listener: (signal: Signal) => void) {
+    // Prevent duplicate subscriptions
+    if (!this.listeners.has(listener)) {
+      logger.debug('subscribed')
+      this.listeners.add(listener)
+    }
+    this.emitter.on('add', listener)
   }
 
   unsubscribe(listener: (signal: Signal) => void) {
+    this.listeners.delete(listener)
     logger.debug('unsubscribed')
     this.emitter.off('add', listener)
   }
+
+  once(listener: (signal: Signal) => void) {
+    this.emitter.once('add', listener)
+  }
 }

packages/signals/signals/src/core/signals/settings.ts

@@ -114,6 +114,7 @@ export class SignalsDebugSettings {
   private storageType = 'sessionStorage' as const
   private static redactionKey = 'segment_signals_debug_redaction_disabled'
   private static ingestionKey = 'segment_signals_debug_ingestion_enabled'
+  private static logSignals = 'segment_signals_debug_log_signals_enabled'
 
   constructor(disableRedaction?: boolean, enableIngestion?: boolean) {
     if (typeof disableRedaction === 'boolean') {
@@ -133,6 +134,7 @@ export class SignalsDebugSettings {
   setAllDebugging = (boolean: boolean) => {
     this.setDebugKey(SignalsDebugSettings.redactionKey, boolean)
     this.setDebugKey(SignalsDebugSettings.ingestionKey, boolean)
+    this.setDebugKey(SignalsDebugSettings.logSignals, boolean)
   }
 
   private setDebugKey = (key: string, enable: boolean): void => {
@@ -168,4 +170,8 @@ export class SignalsDebugSettings {
   getEnableSignalsIngestion = (): boolean => {
     return this.getDebugKey(SignalsDebugSettings.ingestionKey)
   }
+
+  getEnableLogSignals = (): boolean => {
+    return this.getDebugKey(SignalsDebugSettings.logSignals)
+  }
 }

packages/signals/signals/src/core/signals/signals.ts

@@ -129,24 +129,16 @@ export class Signals implements ISignals {
     void this.buffer.clear()
   }
 
-  /**
-   * Disable redaction and enable ingestion of signals.
-   */
-  debug(): void {
-    this.globalSettings.signalsDebug.setAllDebugging(true)
+  // create a reference so we prevent duplicate subscriptions
+  private logSignal = (signal: Signal) => {
+    logger.log(signal.type, signal.data, signal.metadata)
   }
-
   /**
-   * Log signals to the console.
+   * Disable redaction, ingestion of signals, and other debug logging.
    */
-  enableDebugLogging({ signalsOnly } = { signalsOnly: true }): void {
-    if (signalsOnly) {
-      this.signalEmitter.subscribe((signal) => {
-        logger.log(signal.type, signal.data)
-      })
-    } else {
-      logger.enableDebugLogging()
-    }
+  debug(boolean = true): void {
+    this.globalSettings.signalsDebug.setAllDebugging(boolean)
+    this.signalEmitter.subscribe(this.logSignal)
   }
 
   /**