wip

Author: silesky

packages/signals/signals-runtime/src/mobile/mobile-exports-globals.ts

@@ -1,8 +1,9 @@
 // all import directives will be removed in the final build
-import { MobileSignalsRuntime } from './mobile-signals-types'
+import { Signal } from './mobile-signals-types'
+import { ISignalsRuntime } from './mobile-exports'
 
 // This will be appended to the generated code - dts-bundle-generator will not write declare const for whatever reason.
-declare const signals: MobileSignalsRuntime
+declare const signals: ISignalsRuntime<Signal>
 declare const SignalType: {
   Interaction: 'interaction'
   Navigation: 'navigation'

packages/signals/signals-runtime/src/shared/shared-types.ts

@@ -13,6 +13,11 @@ export interface ISignalsRuntime<Signal extends BaseSignal> {
     signalType: SignalType,
     predicate?: (signal: SignalOfType<Signal, SignalType>) => boolean
   ) => SignalOfType<Signal, SignalType> | undefined
+  filter: <SignalType extends Signal['type']>(
+    fromSignal: Signal,
+    signalType: SignalType,
+    predicate?: (signal: SignalOfType<Signal, SignalType>) => boolean
+  ) => SignalOfType<Signal, SignalType>[]
 }
 
 export type JSONPrimitive = string | number | boolean | null

packages/signals/signals-runtime/src/web/web-exports-globals.ts

@@ -1,8 +1,9 @@
 // all import directives will be removed in the final build
-import { WebSignalsRuntime } from './web-exports'
+import { Signal } from './web-exports'
+import { ISignalsRuntime } from './web-exports'
 
 // This will be appended to the generated code - dts-bundle-generator will not write declare const for whatever reason.
-declare const signals: WebSignalsRuntime
+declare const signals: ISignalsRuntime<Signal>
 declare const SignalType: Readonly<{
   Interaction: 'interaction'
   Navigation: 'navigation'

packages/signals/signals-runtime/src/web/web-signals-types.ts

@@ -1,5 +1,4 @@
 import { BaseSignal, JSONValue } from '../shared/shared-types'
-import { ISignalsRuntime } from '../shared/shared-types'
 
 export type SignalTypes = Signal['type']
 
@@ -100,5 +99,3 @@ export type Signal =
   | InstrumentationSignal
   | NetworkSignal
   | UserDefinedSignal
-
-export interface WebSignalsRuntime extends ISignalsRuntime<Signal> {}

packages/signals/signals/src/types/process-signal.ts

@@ -1,4 +1,4 @@
-import { WebSignalsRuntime, Signal } from '@segment/analytics-signals-runtime'
+import { ISignalsRuntime, Signal } from '@segment/analytics-signals-runtime'
 
 /**
  * Types for the signals runtime
@@ -14,7 +14,7 @@ export interface AnalyticsRuntimePublicApi {
 
 export type ProcessSignalScope = {
   analytics: AnalyticsRuntimePublicApi
-  signals: WebSignalsRuntime
+  signals: ISignalsRuntime<Signal>
 } & typeof AnalyticsEnums
 
 export interface ProcessSignal {