From 17a7fc9bfa517e6928bfbb9d0bc6613e8b96c634 Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Tue, 29 Oct 2024 11:58:26 -0500 Subject: [PATCH 1/2] update max buffer size --- packages/signals/signals/src/core/buffer/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/signals/signals/src/core/buffer/index.ts b/packages/signals/signals/src/core/buffer/index.ts index 8b53e5ee6..7d1eb793f 100644 --- a/packages/signals/signals/src/core/buffer/index.ts +++ b/packages/signals/signals/src/core/buffer/index.ts @@ -31,7 +31,7 @@ export class SignalStore implements SignalPersistentStorage { } constructor(settings: { maxBufferSize?: number } = {}) { - this.maxBufferSize = settings.maxBufferSize ?? 25 // TODO: increase this number after development + this.maxBufferSize = settings.maxBufferSize ?? 100 // TODO: increase this number after development this.signalStore = this.createSignalStore() void this.initializeSignalCount() } From 72f02341bc3915498987264e7c9156f25b28291a Mon Sep 17 00:00:00 2001 From: Seth Silesky <5115498+silesky@users.noreply.github.com> Date: Tue, 29 Oct 2024 12:14:29 -0500 Subject: [PATCH 2/2] wip --- .changeset/dull-poets-repeat.md | 5 +++++ packages/signals/signals/src/core/buffer/index.ts | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/dull-poets-repeat.md diff --git a/.changeset/dull-poets-repeat.md b/.changeset/dull-poets-repeat.md new file mode 100644 index 000000000..06fae467a --- /dev/null +++ b/.changeset/dull-poets-repeat.md @@ -0,0 +1,5 @@ +--- +'@segment/analytics-signals': minor +--- + +Update max buffer size to 50 diff --git a/packages/signals/signals/src/core/buffer/index.ts b/packages/signals/signals/src/core/buffer/index.ts index 7d1eb793f..f04f99143 100644 --- a/packages/signals/signals/src/core/buffer/index.ts +++ b/packages/signals/signals/src/core/buffer/index.ts @@ -31,7 +31,7 @@ export class SignalStore implements SignalPersistentStorage { } constructor(settings: { maxBufferSize?: number } = {}) { - this.maxBufferSize = settings.maxBufferSize ?? 100 // TODO: increase this number after development + this.maxBufferSize = settings.maxBufferSize ?? 50 this.signalStore = this.createSignalStore() void this.initializeSignalCount() }