Skip to content

Added missing metric from older analytics packaged #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Added missing metric from older analytics packaged #1189

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a370604
Adding base invoke metric to analytics-next
MichaelGHSeg Nov 13, 2024
86824eb
Modifying unit test for metric changes
MichaelGHSeg Nov 13, 2024
90c270a
Changeset
MichaelGHSeg Nov 13, 2024
df0d800
Fixing test
MichaelGHSeg Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spicy-baboons-care.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@segment/analytics-next': patch
---

Added missing telemetry metric.
4 changes: 3 additions & 1 deletion packages/browser/src/browser/__tests__/integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,9 @@ describe('Dispatch', () => {
})

await sleep(10)
expect(fetchCalls[1].url).toBe('http://new.api.io/m')
expect(fetchCalls.some((call) => call.url === 'http://new.api.io/m')).toBe(
true
)
})
})

Expand Down
1 change: 1 addition & 0 deletions packages/browser/src/core/analytics/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,7 @@ export class Analytics
callback?: Callback
): Promise<DispatchedEvent> {
const ctx = new Context(event)
ctx.stats.increment('analytics_js.invoke', 1, [event.type])
if (isOffline() && !this.options.retryQueue) {
return ctx
}
Expand Down
Loading