Skip to content

Add coverage upload to gh actions ci.yml #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 17, 2024
Merged

Add coverage upload to gh actions ci.yml #1196

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7abdf70
Add coverage upload to gh actions ci.yml
MichaelGHSeg Nov 22, 2024
3b2f81e
Update order and coverage directory
MichaelGHSeg Nov 22, 2024
b78b33e
Enable coverage on test run
MichaelGHSeg Nov 22, 2024
151b240
Testing flags and directory for buildkite pipeline
MichaelGHSeg Nov 22, 2024
726b7b0
Fixing path for coverage
MichaelGHSeg Nov 22, 2024
86be3fb
Enable coverage for tests in buildkite
MichaelGHSeg Dec 4, 2024
1d6044c
Testing coverage generation
MichaelGHSeg Dec 4, 2024
36854f2
Trying another test
MichaelGHSeg Dec 4, 2024
3cb1836
Testing...
MichaelGHSeg Dec 4, 2024
ba54119
Testing browser
MichaelGHSeg Dec 5, 2024
46b24c7
Exempting browser load test from coverage
MichaelGHSeg Dec 5, 2024
484de61
Trying different test set for browser coverage
MichaelGHSeg Dec 5, 2024
b9f9734
Zeroing out coverage thresholds temporarily
MichaelGHSeg Dec 5, 2024
32d3b8f
Removing useless coverage ignore statement
MichaelGHSeg Dec 5, 2024
becfdc5
Adding codecov comments
MichaelGHSeg Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ steps:

- label: '[Browser] Lint + Test'
key: browser-lint-test
Copy link
Contributor

@silesky silesky Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if incomplete, but we probably need to set COVERAGE=true as well?

Copy link
Collaborator Author

@MichaelGHSeg MichaelGHSeg Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Had thought that was set at the top of the file.

env:
SEGMENT_CODECOV_FLAGS: 'browser'
SEGMENT_CODECOV_ARGS: '--dir=./packages/browser/coverage'
agents:
queue: v1
commands:
Expand Down Expand Up @@ -82,6 +85,9 @@ steps:
paths: ['.yarn/cache/']

- label: '[Core] Lint + Test'
env:
SEGMENT_CODECOV_FLAGS: 'core'
SEGMENT_CODECOV_ARGS: '--dir=./packages/core/coverage'
agents:
queue: v1
commands:
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,14 @@ jobs:
restore-keys: |
${{ runner.os }}-turbo-
- run: yarn turbo run --filter='./packages/node*' lint
- run: yarn turbo run --filter='./packages/node*' test
- run: COVERAGE=true yarn turbo run --filter='./packages/node*' test
- run: yarn turbo run --filter='./packages/node-integration-tests' test:perf-and-durability
- uses: codecov/codecov-action@v5
with:
fail_ci_if_error: true
flags: node
directory: ./packages/node/coverage
token: ${{ secrets.CODECOV_TOKEN }}
analytics-node-cf-workers:
name: 'analytics-node QA (Cloudflare Workers)'
runs-on: ubuntu-latest
Expand Down
Loading