From fff66c9a0e32844598567be58557c4de2264270a Mon Sep 17 00:00:00 2001
From: Seth Silesky <5115498+silesky@users.noreply.github.com>
Date: Fri, 14 Feb 2025 18:09:01 -0600
Subject: [PATCH] fix max buffer size default

---
 .changeset/loud-pears-learn.md                   |  5 +++++
 .../signals/signals/src/core/buffer/index.ts     | 16 +++++++---------
 2 files changed, 12 insertions(+), 9 deletions(-)
 create mode 100644 .changeset/loud-pears-learn.md

diff --git a/.changeset/loud-pears-learn.md b/.changeset/loud-pears-learn.md
new file mode 100644
index 000000000..6621dceed
--- /dev/null
+++ b/.changeset/loud-pears-learn.md
@@ -0,0 +1,5 @@
+---
+'@segment/analytics-signals': patch
+---
+
+Fix max buffer size
diff --git a/packages/signals/signals/src/core/buffer/index.ts b/packages/signals/signals/src/core/buffer/index.ts
index 9ee40a548..a1967d355 100644
--- a/packages/signals/signals/src/core/buffer/index.ts
+++ b/packages/signals/signals/src/core/buffer/index.ts
@@ -25,8 +25,10 @@ interface IDBPObjectStoreSignals
     'readonly' | 'readwrite' | 'versionchange'
   > {}
 
+const MAX_BUFFER_SIZE_DEFAULT = 50
+
 interface StoreSettings {
-  maxBufferSize: number
+  maxBufferSize?: number
 }
 export class SignalStoreIndexDB implements SignalPersistentStorage {
   static readonly DB_NAME = 'Segment Signals Buffer'
@@ -50,7 +52,7 @@ export class SignalStoreIndexDB implements SignalPersistentStorage {
   }
 
   constructor(settings: StoreSettings) {
-    this.maxBufferSize = settings.maxBufferSize
+    this.maxBufferSize = settings.maxBufferSize ?? MAX_BUFFER_SIZE_DEFAULT
     this.db = this.initSignalDB()
   }
 
@@ -137,7 +139,7 @@ export class SignalStoreSessionStorage implements SignalPersistentStorage {
   private maxBufferSize: number
 
   constructor(settings: StoreSettings) {
-    this.maxBufferSize = settings.maxBufferSize
+    this.maxBufferSize = settings.maxBufferSize ?? MAX_BUFFER_SIZE_DEFAULT
   }
 
   add(signal: Signal): void {
@@ -216,13 +218,9 @@ export const getSignalBuffer = <
 >(
   settings: SignalBufferSettingsConfig<T>
 ) => {
-  const settingsWithDefaults: StoreSettings = {
-    maxBufferSize: 50,
-    ...settings,
-  }
   const store =
     settings.signalStorage ?? settings.storageType === 'session'
-      ? new SignalStoreSessionStorage(settingsWithDefaults)
-      : new SignalStoreIndexDB(settingsWithDefaults)
+      ? new SignalStoreSessionStorage(settings)
+      : new SignalStoreIndexDB(settings)
   return new SignalBuffer(store)
 }