Merge pull request #342 from tam-carre/master

Add an errorHandler property to constructor options

Author: pooyaj

index.js

@@ -29,6 +29,7 @@ class Analytics {
    *   @property {Object} [axiosInstance] (default: axios.create(options.axiosConfig))
    *   @property {Object} [axiosRetryConfig] (optional)
    *   @property {Number} [retryCount] (default: 3)
+   *   @property {Function} [errorHandler] (optional)
    */
 
   constructor (writeKey, options) {
@@ -50,6 +51,7 @@ class Analytics {
     this.maxQueueSize = options.maxQueueSize || 1024 * 450 // 500kb is the API limit, if we approach the limit i.e., 450kb, we'll flush
     this.flushInterval = options.flushInterval || 10000
     this.flushed = false
+    this.errorHandler = options.errorHandler
     Object.defineProperty(this, 'enable', {
       configurable: false,
       writable: false,
@@ -295,6 +297,10 @@ class Analytics {
         return Promise.resolve(data)
       })
       .catch(err => {
+        if (typeof this.errorHandler === 'function') {
+          return this.errorHandler(err)
+        }
+
         if (err.response) {
           const error = new Error(err.response.statusText)
           done(error)

test.js

@@ -365,6 +365,22 @@ test('flush - respond with an error', async t => {
   await t.throws(client.flush(), 'Bad Request')
 })
 
+test('flush - do not throw on axios failure if errorHandler option is specified', async t => {
+  const errorHandler = spy()
+  const client = createClient({ errorHandler })
+  const callback = spy()
+
+  client.queue = [
+    {
+      message: 'error',
+      callback
+    }
+  ]
+
+  await t.notThrows(client.flush())
+  t.true(errorHandler.calledOnce)
+})
+
 test('flush - time out if configured', async t => {
   const client = createClient({ timeout: 500 })
   const callback = spy()