fix: resolve linting errors and format code

abueide · abueide · commit c7ba9712000a · 2026-03-09T15:19:30.000-05:00
- Fix strict-boolean-expressions for nullable config checks
- Fix nullable string check in QueueFlushingPlugin
- Run prettier on all modified files
diff --git a/packages/core/src/backoff/BackoffManager.ts b/packages/core/src/backoff/BackoffManager.ts
@@ -159,7 +159,9 @@ export class BackoffManager {
       const nextRetryTime = now + backoffSeconds * 1000;
 
       this.logger?.info(
-        `Transient error (${statusCode}): backoff ${backoffSeconds.toFixed(1)}s, attempt ${newRetryCount}/${this.config.maxRetryCount}`
+        `Transient error (${statusCode}): backoff ${backoffSeconds.toFixed(
+          1
+        )}s, attempt ${newRetryCount}/${this.config.maxRetryCount}`
       );
 
       return {
diff --git a/packages/core/src/backoff/RetryManager.ts b/packages/core/src/backoff/RetryManager.ts
@@ -99,7 +99,8 @@ export class RetryManager {
     }
 
     const waitSeconds = Math.ceil((state.waitUntilTime - now) / 1000);
-    const stateType = state.state === 'RATE_LIMITED' ? 'rate limited' : 'backing off';
+    const stateType =
+      state.state === 'RATE_LIMITED' ? 'rate limited' : 'backing off';
     this.logger?.info(
       `Upload blocked: ${stateType}, retry in ${waitSeconds}s (retry ${state.retryCount})`
     );
@@ -113,7 +114,7 @@ export class RetryManager {
    * @param retryAfterSeconds - Delay in seconds from Retry-After header (validated and clamped)
    */
   async handle429(retryAfterSeconds: number): Promise<void> {
-    if (!this.rateLimitConfig?.enabled) {
+    if (this.rateLimitConfig?.enabled !== true) {
       return;
     }
 
@@ -148,7 +149,7 @@ export class RetryManager {
    * Uses exponential backoff to calculate wait time.
    */
   async handleTransientError(): Promise<void> {
-    if (!this.backoffConfig?.enabled) {
+    if (this.backoffConfig?.enabled !== true) {
       return;
     }
 
@@ -224,9 +225,12 @@ export class RetryManager {
           ? Math.max(state.waitUntilTime, waitUntilTime)
           : waitUntilTime;
 
-      const stateType = newState === 'RATE_LIMITED' ? 'Rate limited (429)' : 'Transient error';
+      const stateType =
+        newState === 'RATE_LIMITED' ? 'Rate limited (429)' : 'Transient error';
       this.logger?.info(
-        `${stateType}: waiting ${Math.ceil((finalWaitUntilTime - now) / 1000)}s before retry ${newRetryCount}`
+        `${stateType}: waiting ${Math.ceil(
+          (finalWaitUntilTime - now) / 1000
+        )}s before retry ${newRetryCount}`
       );
 
       return {
@@ -246,7 +250,8 @@ export class RetryManager {
       return 0;
     }
 
-    const { baseBackoffInterval, maxBackoffInterval, jitterPercent } = this.backoffConfig;
+    const { baseBackoffInterval, maxBackoffInterval, jitterPercent } =
+      this.backoffConfig;
 
     // Base exponential backoff: base * 2^retryCount
     const exponentialBackoff = baseBackoffInterval * Math.pow(2, retryCount);
diff --git a/packages/core/src/backoff/UploadStateMachine.ts b/packages/core/src/backoff/UploadStateMachine.ts
@@ -156,7 +156,9 @@ export class UploadStateMachine {
           : waitUntilTime;
 
       this.logger?.info(
-        `Rate limited (429): waiting ${Math.ceil((finalWaitUntilTime - now) / 1000)}s before retry ${newRetryCount}/${this.config.maxRetryCount}`
+        `Rate limited (429): waiting ${Math.ceil(
+          (finalWaitUntilTime - now) / 1000
+        )}s before retry ${newRetryCount}/${this.config.maxRetryCount}`
       );
 
       return {
diff --git a/packages/core/src/backoff/__tests__/BackoffManager.test.ts b/packages/core/src/backoff/__tests__/BackoffManager.test.ts
@@ -187,11 +187,15 @@ describe('BackoffManager', () => {
         expect(await bm.canRetry()).toBe(false);
 
         // Should not be ready 1ms before expected delay
-        jest.spyOn(Date, 'now').mockReturnValue(currentTime + expectedDelays[i] - 1);
+        jest
+          .spyOn(Date, 'now')
+          .mockReturnValue(currentTime + expectedDelays[i] - 1);
         expect(await bm.canRetry()).toBe(false);
 
         // Should be ready at expected delay
-        jest.spyOn(Date, 'now').mockReturnValue(currentTime + expectedDelays[i]);
+        jest
+          .spyOn(Date, 'now')
+          .mockReturnValue(currentTime + expectedDelays[i]);
         expect(await bm.canRetry()).toBe(true);
       }
     });
diff --git a/packages/core/src/plugins/QueueFlushingPlugin.ts b/packages/core/src/plugins/QueueFlushingPlugin.ts
@@ -76,7 +76,9 @@ export class QueueFlushingPlugin extends UtilityPlugin {
   async flush() {
     // Safety: prevent concurrent flush operations
     if (this.flushPromise) {
-      this.analytics?.logger.info('Flush already in progress, waiting for completion');
+      this.analytics?.logger.info(
+        'Flush already in progress, waiting for completion'
+      );
       await this.flushPromise;
       return;
     }
@@ -153,7 +155,7 @@ export class QueueFlushingPlugin extends UtilityPlugin {
 
       const idsToRemove = new Set(messageIds);
       const filteredEvents = state.events.filter(
-        (e) => !e.messageId || !idsToRemove.has(e.messageId)
+        (e) => e.messageId == null || !idsToRemove.has(e.messageId)
       );
 
       return { events: filteredEvents };
diff --git a/packages/core/src/plugins/SegmentDestination.ts b/packages/core/src/plugins/SegmentDestination.ts
@@ -12,11 +12,7 @@ import type { SegmentClient } from '../analytics';
 import { DestinationMetadataEnrichment } from './DestinationMetadataEnrichment';
 import { QueueFlushingPlugin } from './QueueFlushingPlugin';
 import { defaultApiHost, defaultConfig } from '../constants';
-import {
-  translateHTTPError,
-  classifyError,
-  parseRetryAfter,
-} from '../errors';
+import { translateHTTPError, classifyError, parseRetryAfter } from '../errors';
 import { RetryManager } from '../backoff/RetryManager';
 
 const MAX_EVENTS_PER_BATCH = 100;
@@ -66,7 +62,9 @@ export class SegmentDestination extends DestinationPlugin {
    */
   private async uploadBatch(batch: SegmentEvent[]): Promise<BatchResult> {
     const config = this.analytics?.getConfig() ?? defaultConfig;
-    const messageIds = batch.map((e) => e.messageId).filter((id): id is string => !!id);
+    const messageIds = batch
+      .map((e) => e.messageId)
+      .filter((id): id is string => !!id);
 
     try {
       const res = await uploadEvents({
@@ -95,9 +93,12 @@ export class SegmentDestination extends DestinationPlugin {
 
       // Classify error
       const classification = classifyError(res.status, {
-        default4xxBehavior: config.httpConfig?.backoffConfig?.default4xxBehavior,
-        default5xxBehavior: config.httpConfig?.backoffConfig?.default5xxBehavior,
-        statusCodeOverrides: config.httpConfig?.backoffConfig?.statusCodeOverrides,
+        default4xxBehavior:
+          config.httpConfig?.backoffConfig?.default4xxBehavior,
+        default5xxBehavior:
+          config.httpConfig?.backoffConfig?.default5xxBehavior,
+        statusCodeOverrides:
+          config.httpConfig?.backoffConfig?.statusCodeOverrides,
         rateLimitEnabled: config.httpConfig?.rateLimitConfig?.enabled,
       });
 
@@ -233,7 +234,9 @@ export class SegmentDestination extends DestinationPlugin {
 
     // Handle successes - dequeue
     if (aggregation.successfulMessageIds.length > 0) {
-      await this.queuePlugin.dequeueByMessageIds(aggregation.successfulMessageIds);
+      await this.queuePlugin.dequeueByMessageIds(
+        aggregation.successfulMessageIds
+      );
 
       // Reset retry manager on success
       if (this.retryManager) {
@@ -249,7 +252,9 @@ export class SegmentDestination extends DestinationPlugin {
 
     // Handle permanent errors - dequeue (drop)
     if (aggregation.permanentErrorMessageIds.length > 0) {
-      await this.queuePlugin.dequeueByMessageIds(aggregation.permanentErrorMessageIds);
+      await this.queuePlugin.dequeueByMessageIds(
+        aggregation.permanentErrorMessageIds
+      );
       this.analytics?.logger.error(
         `Dropped ${aggregation.permanentErrorMessageIds.length} events due to permanent errors`
       );
@@ -301,7 +306,10 @@ export class SegmentDestination extends DestinationPlugin {
     const config = analytics.getConfig();
 
     // Initialize retry manager (handles both 429 rate limiting and transient errors)
-    if (config.httpConfig?.rateLimitConfig || config.httpConfig?.backoffConfig) {
+    if (
+      config.httpConfig?.rateLimitConfig ||
+      config.httpConfig?.backoffConfig
+    ) {
       this.retryManager = new RetryManager(
         config.writeKey,
         config.storePersistor,
