Skip to content

Commit e329746

Browse files
abueideclaude
abueide
and
claude
committed
chore(ci): remove E2E devbox infra, fix CI to run tests
- Remove devbox E2E scripts, nix flake, shells/, and GitHub workflows (E2E infra migrated to hosted devbox plugin in PR #1125) - Merge shells/devbox-fast.json into root devbox.json - Add nodejs@22 to devbox packages (was relying on runner's system node) - Fix api.test.ts missing keepalive expectation (broken since #1120) - Add yarn test and yarn typescript to CI build script - Reorder CI pipeline: lint → typecheck → test → build - Add commitlint CI check to validate PR titles - Remove E2E references from package.json bootstrap/scripts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent d30a158 commit e329746

29 files changed

+98
-1396
lines changed

‎.github/workflows/ci-fast.yml‎

Lines changed: 0 additions & 24 deletions
This file was deleted.

‎.github/workflows/ci.yml‎

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
name: CI
2+
3+
on:
4+
push:
5+
branches: [master, beta]
6+
pull_request:
7+
branches: [master, beta]
8+
9+
concurrency:
10+
group: ci-${{ github.ref }}
11+
cancel-in-progress: true
12+
13+
jobs:
14+
ci:
15+
name: Lint + Build + Test
16+
runs-on: ubuntu-latest
17+
steps:
18+
- uses: actions/checkout@v4
19+
- name: Install devbox
20+
uses: jetify-com/devbox-install-action@v0.14.0
21+
- name: Install dependencies
22+
run: devbox run ci:install
23+
- name: Lint (eslint)
24+
run: devbox run lint
25+
- name: Lint (formatting)
26+
run: devbox run format-check
27+
- name: Build
28+
run: devbox run build
29+
- name: Typecheck
30+
run: devbox run typecheck
31+
- name: Test
32+
run: devbox run test
33+
34+
commitlint:
35+
name: Commitlint
36+
if: github.event_name == 'pull_request'
37+
runs-on: ubuntu-latest
38+
steps:
39+
- uses: actions/checkout@v4
40+
- name: Install devbox
41+
uses: jetify-com/devbox-install-action@v0.14.0
42+
- name: Install dependencies
43+
run: devbox run ci:install
44+
- name: Validate PR title
45+
run: devbox run ci:commitlint
46+
env:
47+
PR_TITLE: ${{ github.event.pull_request.title }}

‎.github/workflows/release.yml‎

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,29 @@ concurrency:
1717
cancel-in-progress: true
1818

1919
jobs:
20-
fast-checks:
21-
name: Build + Lint
20+
ci:
21+
name: Lint + Build + Test
2222
runs-on: ubuntu-latest
2323
steps:
2424
- uses: actions/checkout@v4
25-
- name: devbox installer
25+
- name: Install devbox
2626
uses: jetify-com/devbox-install-action@v0.14.0
27-
with:
28-
project-path: shells/devbox-fast.json
29-
enable-cache: 'false'
30-
- name: build
31-
run: devbox run --config=shells/devbox-fast.json build
27+
- name: Install dependencies
28+
run: devbox run ci:install
29+
- name: Lint (eslint)
30+
run: devbox run lint
31+
- name: Lint (formatting)
32+
run: devbox run format-check
33+
- name: Build
34+
run: devbox run build
35+
- name: Typecheck
36+
run: devbox run typecheck
37+
- name: Test
38+
run: devbox run test
3239

3340
release:
3441
name: Release (${{ inputs.type }})
35-
needs: [fast-checks]
42+
needs: [ci]
3643
runs-on: ubuntu-latest
3744
environment: Publish
3845
permissions:
@@ -52,30 +59,27 @@ jobs:
5259
git checkout -B beta HEAD
5360
git push origin beta --force
5461
55-
- name: devbox installer
62+
- name: Install devbox
5663
uses: jetify-com/devbox-install-action@v0.14.0
57-
with:
58-
project-path: shells/devbox-fast.json
59-
enable-cache: 'false'
6064

6165
- name: Release (dry-run)
6266
if: inputs.type == 'dry-run'
63-
run: devbox run --config=shells/devbox-fast.json release-dry-run
67+
run: devbox run release-dry-run
6468
env:
6569
GH_TOKEN: ${{ github.token }}
6670

6771
- name: Release (beta)
6872
if: inputs.type == 'beta'
69-
run: devbox run -e GITHUB_REF=refs/heads/beta --config=shells/devbox-fast.json release
73+
run: devbox run -e GITHUB_REF=refs/heads/beta release
7074
env:
7175
GH_TOKEN: ${{ github.token }}
7276

7377
- name: Release (production)
7478
if: inputs.type == 'production'
75-
run: devbox run --config=shells/devbox-fast.json release
79+
run: devbox run release
7680
env:
7781
GH_TOKEN: ${{ github.token }}
7882

7983
- name: Update Apps
8084
if: inputs.type == 'production'
81-
run: devbox run --config=shells/devbox-fast.json update-apps
85+
run: devbox run update-apps

‎.husky/pre-commit‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
#!/usr/bin/env sh
22
. "$(dirname -- "$0")/_/husky.sh"
33

4-
yarn lint && yarn typescript && yarn test
4+
yarn lint && yarn typecheck && yarn test

‎devbox.json‎

Lines changed: 25 additions & 86 deletions
Original file line numberDiff line numberDiff line change
@@ -5,103 +5,42 @@
55
"version": "latest",
66
"platforms": ["x86_64-darwin", "aarch64-darwin"]
77
},
8+
"nodejs": "22",
89
"yarn-berry": "latest",
10+
"jq": "latest",
911
"treefmt": "latest",
1012
"nixfmt": "latest",
11-
"shfmt": "latest",
12-
"jdk17": "latest",
13-
"gradle": "latest",
14-
"jq": "latest",
15-
"netcat": "latest",
16-
"path:./nix#android-sdk": ""
13+
"shfmt": "latest"
1714
},
1815
"shell": {
1916
"init_hook": [
20-
"echo 'Welcome to analytics-react-native devbox!' > /dev/null",
21-
". $DEVBOX_PROJECT_ROOT/scripts/shared/common.sh",
22-
"if [ \"$(uname -s)\" = \"Darwin\" ]; then . $DEVBOX_PROJECT_ROOT/scripts/ios/env.sh; fi",
23-
". $DEVBOX_PROJECT_ROOT/scripts/android/env.sh",
24-
"echo 'Android SDK env configured (details: wiki/devbox.md#devbox-android).'"
17+
"export PROJECT_ROOT=\"$(git rev-parse --show-toplevel 2>/dev/null || echo $DEVBOX_PROJECT_ROOT)\"",
18+
"export PATH=\"$PROJECT_ROOT/node_modules/.bin:$PATH\"",
19+
"if [ ! -d \"$PROJECT_ROOT/node_modules\" ]; then echo 'Running yarn install...'; yarn install; fi",
20+
"if [ ! -f \"$PROJECT_ROOT/packages/core/src/info.ts\" ]; then yarn core prebuild; fi",
21+
"if [ ! -d \"$PROJECT_ROOT/.husky/_\" ]; then yarn husky install; fi"
2522
],
2623
"scripts": {
27-
"clean": [
28-
"rm -rf $DEVBOX_PROJECT_ROOT/examples/E2E/ios/Podfile.lock",
29-
"rm -rf $DEVBOX_PROJECT_ROOT/examples/E2E/ios/Pods",
30-
"cd $DEVBOX_PROJECT_DIR/examples/E2E/android && gradle clean",
31-
"yarn cache clean",
32-
"find $DEVBOX_PROJECT_DIR -type d -name node_modules -exec rmdir {} \\;"
33-
],
34-
"build": ["bash $SCRIPTS_DIR/build.sh"],
35-
"format": ["treefmt"],
36-
"lint": ["treefmt --fail-on-change"],
37-
"test-android": ["bash $SCRIPTS_DIR/android/test.sh"],
38-
"test-ios": ["bash $SCRIPTS_DIR/ios/test.sh"],
39-
"act-ci": [
40-
"bash $SCRIPTS_DIR/act-ci.sh --platform ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-24.04"
41-
],
42-
"setup-android": ["bash $SCRIPTS_DIR/android/setup.sh"],
43-
"setup-ios": ["bash $SCRIPTS_DIR/ios/setup.sh"],
44-
"start-emulator": ["bash $SCRIPTS_DIR/android/manager.sh start"],
45-
"start-ios": ["bash $SCRIPTS_DIR/ios/manager.sh start"],
46-
"start-android-minsdk": ["bash $SCRIPTS_DIR/android/manager.sh start"],
47-
"start-android-latest": [
48-
"AVD_FLAVOR=latest bash $SCRIPTS_DIR/android/manager.sh start"
49-
],
50-
"start-android": ["bash $SCRIPTS_DIR/android/manager.sh start"],
24+
"ci:install": ["yarn install --immutable"],
25+
"ci:commitlint": ["bash -c 'echo \"$PR_TITLE\" | yarn commitlint'"],
26+
"build": ["yarn build"],
27+
"test": ["yarn test"],
28+
"typecheck": ["yarn typecheck"],
29+
"lint": ["yarn lint"],
30+
"format": ["yarn format"],
31+
"format-check": ["yarn format:check"],
32+
"clean": ["yarn clean"],
33+
"release": ["yarn install --immutable", "yarn build", "yarn release"],
34+
"release-dry-run": [
35+
"yarn install --immutable",
36+
"yarn build",
37+
"yarn multi-semantic-release --dry-run"
38+
],
39+
"sync-versions": ["bash $PROJECT_ROOT/sync-versions.sh"],
5140
"update-apps": [
5241
"yarn install --no-immutable",
53-
"yarn e2e install --no-immutable",
5442
"yarn example install --no-immutable"
55-
],
56-
"update-shells": [
57-
"devbox update",
58-
"devbox update --config=shells/devbox-fast.json",
59-
"devbox update --config=shells/devbox-android.json",
60-
"devbox update --config=shells/devbox-ios.json"
61-
],
62-
"reset-android": [
63-
"rm -rf ~/.android/avd",
64-
"rm -f ~/.android/adbkey*",
65-
"echo \"AVDs and adb keys removed. Recreate via devbox run start-android* as needed.\""
66-
],
67-
"reset-ios": [
68-
"xcrun simctl shutdown all || true",
69-
"xcrun simctl erase all || true",
70-
"xcrun simctl delete all || true",
71-
"xcrun simctl delete unavailable || true",
72-
"killall -9 com.apple.CoreSimulatorService 2>/dev/null || true",
73-
"echo \"Simulators reset via simctl. Recreate via devbox run start-ios.\""
74-
],
75-
"stop-android": [
76-
"if command -v adb >/dev/null 2>&1; then",
77-
" devices=$(adb devices -l 2>/dev/null | tail -n +2 | awk '{print $1}' | tr '\\n' ' ');",
78-
" if [[ -n \"$devices\" ]]; then",
79-
" echo \"Stopping Android emulators: $devices\";",
80-
" for d in $devices; do adb -s \"$d\" emu kill >/dev/null 2>&1 || true; done;",
81-
" else",
82-
" echo \"No Android emulators detected via adb.\";",
83-
" fi;",
84-
"else",
85-
" echo \"adb not found; skipping Android emulator shutdown.\";",
86-
"fi",
87-
"pkill -f \"emulator@\" >/dev/null 2>&1 || true",
88-
"echo \"Android emulators stopped (if any were running).\""
89-
],
90-
"stop-ios": [
91-
"if command -v xcrun >/dev/null 2>&1 && xcrun -f simctl >/dev/null 2>&1; then",
92-
" if xcrun simctl list devices booted | grep -q \"Booted\"; then",
93-
" echo \"Shutting down booted iOS simulators...\";",
94-
" xcrun simctl shutdown all >/dev/null 2>&1 || true;",
95-
" else",
96-
" echo \"No booted iOS simulators detected.\";",
97-
" fi;",
98-
"else",
99-
" echo \"simctl not available; skipping iOS shutdown.\";",
100-
"fi",
101-
"echo \"iOS simulators shutdown (if any were running).\""
102-
],
103-
"stop": ["devbox run stop-android", "devbox run stop-ios"],
104-
"test": ["devbox run test-android", "devbox run test-ios"]
43+
]
10544
}
10645
}
10746
}

‎nix/flake.lock‎

Lines changed: 0 additions & 27 deletions
This file was deleted.

‎nix/flake.nix‎

Lines changed: 0 additions & 74 deletions
This file was deleted.

‎nix/platform-versions.json‎

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)