Skip to content

Commit 5f53cbb

Browse files
committed
Fixing tests for new atomic members
1 parent 98974b2 commit 5f53cbb

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Sources/Segment/Utilities/Telemetry.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ public class Telemetry: Subscriber {
7171

7272
internal var session: any HTTPSession
7373
internal var host: String = HTTPClient.getDefaultAPIHost()
74-
@Atomic var sampleRate: Double = 1.0 // inital sample rate should be 1.0, will be downsampled on start
74+
@Atomic internal var sampleRate: Double = 1.0 // inital sample rate should be 1.0, will be downsampled on start
75+
internal var sampleRateTest: Atomic<Double> { _sampleRate }
7576
private var flushTimer: Int = 30
7677
internal var maxQueueSize: Int = 20
7778
var errorLogSizeMax: Int = 4000
@@ -88,6 +89,7 @@ public class Telemetry: Subscriber {
8889
@Atomic internal var started = false
8990
@Atomic private var rateLimitEndTime: TimeInterval = 0
9091
@Atomic internal var flushFirstError = true
92+
internal var flushFirstErrorTest: Atomic<Bool> { _flushFirstError }
9193
private var telemetryQueue = DispatchQueue(label: "telemetryQueue")
9294
private var updateQueue = DispatchQueue(label: "updateQueue")
9395
private var telemetryTimer: QueueTimer?

Tests/Segment-Tests/Telemetry_Tests.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class TelemetryTests: XCTestCase {
1212
self.errors.append("\(error)")
1313
}
1414
errors.removeAll()
15-
Telemetry.shared.sampleRate = 1.0
15+
Telemetry.shared.sampleRateTest.set(1.0)
1616
mockTelemetryHTTPClient()
1717
}
1818

@@ -29,12 +29,12 @@ class TelemetryTests: XCTestCase {
2929
}
3030

3131
func testTelemetryStart() {
32-
Telemetry.shared.sampleRate = 0.0
32+
Telemetry.shared.sampleRateTest.set(0.0)
3333
Telemetry.shared.enable = true
3434
Telemetry.shared.start()
3535
XCTAssertFalse(Telemetry.shared.started)
3636

37-
Telemetry.shared.sampleRate = 1.0
37+
Telemetry.shared.sampleRateTest.set(1.0)
3838
Telemetry.shared.start()
3939
XCTAssertTrue(Telemetry.shared.started)
4040
XCTAssertTrue(errors.isEmpty)
@@ -116,7 +116,7 @@ class TelemetryTests: XCTestCase {
116116

117117
func testHTTPException() {
118118
mockTelemetryHTTPClient(shouldThrow: true)
119-
Telemetry.shared.flushFirstError = true
119+
Telemetry.shared.flushFirstErrorTest.set(true)
120120
Telemetry.shared.enable = true
121121
Telemetry.shared.start()
122122
Telemetry.shared.error(metric: Telemetry.INVOKE_METRIC, log: "log") { $0["error"] = "test" }

0 commit comments

Comments
 (0)