fix(cookies): null values should delete cookies (#130)

Author: Fathy Boundjadj

HISTORY.md

@@ -1,3 +1,7 @@
+# 3.13.2 / 2020-05-21
+
+- fix: null values should delete cookies
+
 # 3.13.1 / 2020-05-04
 
 - refactor: remove third party dependency ndhoule/each

lib/cookie.js

@@ -73,7 +73,7 @@ Cookie.prototype.options = function(options) {
 Cookie.prototype.set = function(key, value) {
   try {
     value = window.JSON.stringify(value);
-    cookie(key, value, clone(this._options));
+    cookie(key, value === 'null' ? null : value, clone(this._options));
     return true;
   } catch (e) {
     return false;

package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-core",
   "author": "Segment <[email protected]>",
-  "version": "3.13.1",
+  "version": "3.13.2",
   "description": "The hassle-free way to integrate analytics into any web application.",
   "keywords": [
     "analytics",

test/cookie.test.js

@@ -49,6 +49,11 @@ describe('cookie', function() {
       cookie.remove('cookie-remove');
       assert(cookie.get('cookie-remove') === null);
     });
+
+    it('null cookie should be null after setting', function() {
+      cookie.set('cookie-null', null);
+      assert(cookie.get('cookie-null') === null);
+    });
   });
 
   describe('#options', function() {