Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Commit 9548983

Browse files
author
King Long Tse
authored
Optionally prevent merge when HISTORY.md isn't updated (#156)
* added mergeable * removed changelog CI step * magic text to skip enforcing HISTORY.md updates
1 parent 9c05c8d commit 9548983

File tree

4 files changed

+14
-34
lines changed

4 files changed

+14
-34
lines changed

.circleci/changelog-check.sh

Lines changed: 0 additions & 19 deletions
This file was deleted.

.circleci/config.yml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,6 @@ jobs:
4949
- run: yarn run snyk test --severity-threshold=high
5050
- run: yarn run snyk monitor
5151

52-
changelog:
53-
<<: *defaults
54-
steps:
55-
- checkout
56-
- run: make release-test
57-
5852
publish:
5953
<<: *defaults
6054
steps:
@@ -68,10 +62,6 @@ workflows:
6862
version: 2
6963
test_and_publish:
7064
jobs:
71-
- changelog:
72-
filters:
73-
tags:
74-
only: /.*/
7565
- test:
7666
filters:
7767
tags:
@@ -87,7 +77,6 @@ workflows:
8777
- publish:
8878
requires:
8979
- test
90-
- changelog
9180
filters:
9281
tags:
9382
only: /v[0-9]+(\.[0-9]+)*(-.+)?/

.github/mergeable.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
version: 2
2+
mergeable:
3+
- when: pull_request.*
4+
validate:
5+
- do: or
6+
validate:
7+
- do: dependent
8+
changed:
9+
file: '**/*'
10+
required: ['HISTORY.md']
11+
- do: description
12+
must_include:
13+
regex: 'New version is not required'
14+
message: 'Should cut a new version or explicitly documents new version not required in description'

Makefile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,4 @@ test-e2e:
8888
npx codeceptjs run --steps
8989
.PHONY: test-e2e
9090

91-
release-test:
92-
sh .circleci/changelog-check.sh
93-
.PHONY: release-test
94-
9591
.DEFAULT_GOAL = test

0 commit comments

Comments
 (0)