remove arg validation on optional parameter (#136)

wavetylor · web-flow · commit 365206507ae8 · 2023-12-08T10:07:58.000-05:00
diff --git a/pkg/cmd/ctlstore/main.go b/pkg/cmd/ctlstore/main.go
@@ -78,7 +78,7 @@ type reflectorCliConfig struct {
 }
 
 type multiReflectorConfig struct {
-	LDBPaths []string `conf:"ldb-paths" help:"list of ldbs, each ldb is managed by a unique reflector" validate:"nonzero"`
+	LDBPaths []string `conf:"ldb-paths" help:"list of ldbs, each ldb is managed by a unique reflector"`
 }
 
 type executiveCliConfig struct {
@@ -495,6 +495,10 @@ func multiReflector(ctx context.Context, args []string) {
 		enableDebug()
 	}
 
+	if len(cliCfg.MultiReflector.LDBPaths) <= 1 {
+		panic("multi-reflector mode requires at least 2 ldb paths")
+	}
+
 	var promHandler *prometheus.Handler
 	if len(cliCfg.MetricsBind) > 0 {
 		promHandler = &prometheus.Handler{}

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ type reflectorCliConfig struct {`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`type multiReflectorConfig struct {`
`81`		- LDBPaths []string `conf:"ldb-paths" help:"list of ldbs, each ldb is managed by a unique reflector" validate:"nonzero"`
	`81`	+ LDBPaths []string `conf:"ldb-paths" help:"list of ldbs, each ldb is managed by a unique reflector"`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`type executiveCliConfig struct {`
`@@ -495,6 +495,10 @@ func multiReflector(ctx context.Context, args []string) {`
`495`	`495`	`enableDebug()`
`496`	`496`	`}`
`497`	`497`
	`498`	`+ if len(cliCfg.MultiReflector.LDBPaths) <= 1 {`
	`499`	`+ panic("multi-reflector mode requires at least 2 ldb paths")`
	`500`	`+ }`
	`501`	`+`
`498`	`502`	`var promHandler *prometheus.Handler`
`499`	`503`	`if len(cliCfg.MetricsBind) > 0 {`
`500`	`504`	`promHandler = &prometheus.Handler{}`