Skip to content

Commit a72c947

Browse files
Swap with @faker-js/faker, update imports (#1421)
* Swap with @faker-js/faker, update imports * Bump node engine version to 14+ * Update imports based on PR feedback from faker-js maintainers * Update faker to beta version * Simplify faker imports, but use named import vs. default for future-proofing * Update to non-beta version of faker * Rerun CI
1 parent c87cd44 commit a72c947

File tree

16 files changed

+21
-21
lines changed

16 files changed

+21
-21
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
runs-on: ubuntu-latest
1414
strategy:
1515
matrix:
16-
node_version: [12]
16+
node_version: [14.18]
1717
steps:
1818
- uses: actions/checkout@master
1919
- uses: actions/setup-node@v1

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
12.20
1+
14.18

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"chromatic": "npx chromatic"
5454
},
5555
"engines": {
56-
"node": ">=12"
56+
"node": ">=14"
5757
},
5858
"dependencies": {
5959
"@babel/runtime": "^7.1.2",
@@ -92,6 +92,7 @@
9292
"@babel/preset-react": "^7.0.0",
9393
"@babel/register": "^7.0.0",
9494
"@blueprintjs/icons": "^3.31.0",
95+
"@faker-js/faker": "^6.1.2",
9596
"@reactions/component": "^2.0.2",
9697
"@rollup/plugin-babel": "^5.2.1",
9798
"@rollup/plugin-commonjs": "^15.1.0",
@@ -123,7 +124,6 @@
123124
"eslint-plugin-react-hooks": "^4.2.0",
124125
"eslint-plugin-sort-destructure-keys": "^1.3.5",
125126
"eslint-plugin-standard": "4.0.0",
126-
"faker": "^5.5.3",
127127
"file-loader": "^6.0.0",
128128
"fs-extra": "^7.0.0",
129129
"husky": "^4.0.10",

src/badges/stories/index.stories.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react'
2+
import { faker } from '@faker-js/faker'
23
import { storiesOf } from '@storybook/react'
3-
import faker from 'faker'
44
import Box from 'ui-box'
55
import { Badge, Pill } from '..'
66
import { ThemeConsumer } from '../../theme'

src/file-uploader/__tests__/FileCard.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react'
2+
import { faker } from '@faker-js/faker'
23
import { render, screen } from '@testing-library/react'
3-
import faker from 'faker'
44
import humanize from 'humanize-plus'
55
import { MimeType } from '../../constants'
66
import FileCard from '../src/FileCard'

src/file-uploader/__tests__/FileUploader.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react'
2+
import { faker } from '@faker-js/faker'
23
import { render, screen, fireEvent, cleanup } from '@testing-library/react'
3-
import faker from 'faker'
44
import { Key, MimeType } from '../../constants'
55
import { buildFiles } from '../../test/utils'
66
import FileUploader from '../src/FileUploader'

src/lib/__tests__/array-to-csv.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import faker from 'faker'
1+
import { faker } from '@faker-js/faker'
22
import arrayToCsv from '../array-to-csv'
33

44
describe('arrayToCsv', () => {

src/table/stories/EditableTable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react'
2-
import faker from 'faker'
2+
import { faker } from '@faker-js/faker'
33
import { Table } from '..'
44
import { Pane } from '../../layers'
55
import { SegmentedControl } from '../../segmented-control'

src/table/stories/VirtualTable.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React, { Fragment } from 'react'
2-
import faker from 'faker'
2+
import { faker } from '@faker-js/faker'
33
import { Table } from '..'
44
import { Pane } from '../../layers'
55
import { minorScale } from '../../scales'

src/table/stories/index.stories.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React from 'react'
2+
import { faker } from '@faker-js/faker'
23
import Component from '@reactions/component'
34
import { storiesOf } from '@storybook/react'
4-
import faker from 'faker'
55
import Box from 'ui-box'
66
import { Table } from '..'
77
import { Pane } from '../../layers'

0 commit comments

Comments
 (0)