@@ -60,7 +60,7 @@ type Transport struct {
60
60
61
61
// Time limit set for establishing connections to the kafka cluster. This
62
62
// limit includes all round trips done to establish the connections (TLS
63
- // hadbhaske , SASL negotiation, etc...).
63
+ // handshake , SASL negotiation, etc...).
64
64
//
65
65
// Defaults to 5s.
66
66
DialTimeout time.Duration
@@ -150,7 +150,7 @@ func (t *Transport) CloseIdleConnections() {
150
150
// package.
151
151
//
152
152
// The type of the response message will match the type of the request. For
153
- // exmple , if RoundTrip was called with a *fetch.Request as argument, the value
153
+ // example , if RoundTrip was called with a *fetch.Request as argument, the value
154
154
// returned will be of type *fetch.Response. It is safe for the program to do a
155
155
// type assertion after checking that no error was returned.
156
156
//
@@ -413,14 +413,16 @@ func (p *connPool) roundTrip(ctx context.Context, req Request) (Response, error)
413
413
case * meta.Response :
414
414
m := req .(* meta.Request )
415
415
// If we get here with allow auto topic creation then
416
- // we didn't have that topic in our cache so we should update
416
+ // we didn't have that topic in our cache, so we should update
417
417
// the cache.
418
418
if m .AllowAutoTopicCreation {
419
419
topicsToRefresh := make ([]string , 0 , len (resp .Topics ))
420
420
for _ , topic := range resp .Topics {
421
- // fixes issue 806: don't refresh topics that failed to create,
422
- // it may means kafka doesn't enable auto topic creation.
423
- // This causes the library to hang indefinitely, same as createtopics process.
421
+ // Don't refresh topics that failed to create, since that may
422
+ // mean that enable automatic topic creation is not enabled.
423
+ // That causes the library to hang indefinitely, same as
424
+ // don't refresh topics that failed to create,
425
+ // createtopics process. Fixes issue 806.
424
426
if topic .ErrorCode != 0 {
425
427
continue
426
428
}
0 commit comments