Remove StatusOther

yolken-segment · yolken-segment · commit f34eda9d0bff · 2021-04-09T14:09:07.000-07:00
diff --git a/pkg/validation/kubeconform.go b/pkg/validation/kubeconform.go
@@ -3,6 +3,7 @@ package validation
 import (
 	"context"
 
+	log "github.com/sirupsen/logrus"
 	"github.com/yannh/kubeconform/pkg/validator"
 )
 
@@ -62,6 +63,8 @@ func kStatusToStatus(kStatus validator.Status) Status {
 	case validator.Empty:
 		return StatusEmpty
 	default:
-		return StatusOther
+		// This shouldn't happen
+		log.Warnf("Got unexpected status from kubeconform: %+v", kStatus)
+		return StatusEmpty
 	}
 }
diff --git a/pkg/validation/result.go b/pkg/validation/result.go
@@ -9,7 +9,6 @@ const (
 	StatusError   Status = "error"
 	StatusSkipped Status = "skipped"
 	StatusEmpty   Status = "empty"
-	StatusOther   Status = "other"
 )
 
 // CheckType represents the type of check that has been done.

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@ package validation`
`3`	`3`	`import (`
`4`	`4`	`"context"`
`5`	`5`
	`6`	`+ log "github.com/sirupsen/logrus"`
`6`	`7`	`"github.com/yannh/kubeconform/pkg/validator"`
`7`	`8`	`)`
`8`	`9`
`@@ -62,6 +63,8 @@ func kStatusToStatus(kStatus validator.Status) Status {`
`62`	`63`	`case validator.Empty:`
`63`	`64`	`return StatusEmpty`
`64`	`65`	`default:`
`65`		`- return StatusOther`
	`66`	`+ // This shouldn't happen`
	`67`	`+ log.Warnf("Got unexpected status from kubeconform: %+v", kStatus)`
	`68`	`+ return StatusEmpty`
`66`	`69`	`}`
`67`	`70`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@ const (`
`9`	`9`	`StatusError Status = "error"`
`10`	`10`	`StatusSkipped Status = "skipped"`
`11`	`11`	`StatusEmpty Status = "empty"`
`12`		`- StatusOther Status = "other"`
`13`	`12`	`)`
`14`	`13`
`15`	`14`	`// CheckType represents the type of check that has been done.`