Merge branch 'master' into enduseradmin

Author: sanscontext

.github/PULL_REQUEST_TEMPLATE.md

@@ -4,8 +4,13 @@
 
 <!--Tell us what you did and why-->
 
+### Merge timing
+<!-- When should this get merged/published?
+- ASAP once approved?
+- On a specific date?
+- Depending on a specific project?-->
 
 ### Related issues (optional)
 
-<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'.
-    Or link to full URLs to issues or pull requests in other Github projects -->
+<!--Refer to related PRs or issues: #1234 or 'Closes #1234'.
+    Or paste full URLs to issues or pull requests in other Github projects -->

CODEOWNERS

@@ -18,16 +18,16 @@ CODEOWNERS  @sanscontext @XavierAgostini @danielstjules @stephment
 
 
 # Libraries owners
-/src/connections/catalog/libraries  @osamakhn @bsneed @lubird
+/src/connections/catalog/libraries  @osamakhn @bsneed @lubird @pooyaj @juliofarah
 
 
 # Destination owners
-/src/connections/destinations   @n2parko @danielstjules @benhorowitz
+/src/connections/destinations  @n2parko @danielstjules @benhorowitz
 # temporary removal: @carlosmecha
 
 
 # Privacy owners
-/src/privacy    @notfelineit @aliya-dossa
+/src/privacy    @notfelineit
 
 
 # Protocols owners

README.md

@@ -53,7 +53,7 @@ See the [Contributor Guide](contributors.md) for more info.
 
 **At minimum you must open a PR so the docs team gets a notification. Do not merge directly to master.**
 
-- **Just fixing a typo**? -> No review needed, you can admin-merge your PR with our blessings.
+- **Just fixing a typo**? -> No review needed, but please label it FIX in the PR subject so we know not to worry. You can then admin-merge your PR with our blessings.
 
 - **Delta of <20 words or ~150 characters**? -> Yes, but a minor review. Open a PR and tag @sanscontext, who'll review mostly for formatting and copy issues.
 
@@ -98,7 +98,7 @@ Once the PR is merged, the docs site rebuilds and the changes are live!
 
 ### Draft PRs
 
-If you're doing a substantial change and you're going to want to spend a few weeks on it, use [Github's Draft PRs feature](https://help.github.com/en/articles/about-pull-requests#draft-pull-requests), or add `WIP` to the title of your PR. This lets us know to ignore the PR until you're ready.
+If you're doing a substantial change and you're going to want to spend a few weeks on it, use [Github's Draft PRs feature](https://help.github.com/en/articles/about-pull-requests#draft-pull-requests), or add `WIP` to the title of your PR. This lets us know to ignore the PR until you're ready (otherwise Laura will ping you weekly about it!).
 
 
 ## How the docs build works
@@ -134,7 +134,7 @@ The most interesting ones are:
 
 ### Images
 
-**All images should be saved locally! No linking to 3rd party-hosted images!** Images are published to our CDN from the build step.
+**Save all images locally! No linking to 3rd party-hosted images!** Images are published to our CDN from the build step, and this means they won't go missing if the hosting service dujour goes out of business.
 
 There are no _enforced_ naming conventions at this time. Files that start with an underscore are ignored by Jekyll. Anything you see with `asset` was dowloaded by a script to migrate it out of Contents.io.
 

_config.yml

@@ -32,7 +32,7 @@ defaults:
       integration_type: source
       layout: integration
   - scope:
-      path: "connections/warehouses/catalog"
+      path: "connections/storage/catalog"
     values:
       integration_type: warehouse
       landing: true

js/headings-anchors/index.js

@@ -2,7 +2,7 @@ import ClipboardJS from 'clipboard'
 import tippy from 'tippy.js'
 
 const COMPONENT_SELECTOR = '[data-headings-anchors]'
-const HEADINGS_SELECTOR = 'h1, h2, h3, h4'
+const HEADINGS_SELECTOR = 'h1, h2, h3, h4, h5'
 
 export default function () {
   const components = document.querySelectorAll(COMPONENT_SELECTOR)
@@ -11,30 +11,29 @@ export default function () {
     const headings = components[i].querySelectorAll(HEADINGS_SELECTOR)
 
     for (let i = 0; i < headings.length; i++) {
-      const tooltip = tippy(headings[i], {
-        content: 'Copied!',
-        theme: 'dark',
-        placement: 'top-start',
-        distance: 5,
-        trigger: 'manual'
-      })
-
-      const clipboard = new ClipboardJS(headings[i], {
-        text: () => {
-          history.replaceState({}, '', '#' + headings[i].getAttribute('id'))
-          return window.location.href
-        }
-      })
-
-      clipboard.on('success', function(e) {
-        tooltip.show()
-
-        setTimeout(() => {
-          tooltip.hide()
-        }, 700)
-    
-        e.clearSelection()
-      })
+      if (!headings[i].classList.contains('media-thumbnail__heading') && !headings[i].classList.contains('media-icon__heading')) {
+        const tooltip = tippy(headings[i], {
+          content: 'Copied!',
+          theme: 'dark',
+          placement: 'top-start',
+          distance: 5,
+          trigger: 'manual'
+        })
+  
+        const clipboard = new ClipboardJS(headings[i], {
+          text: () => `${window.location.origin}${window.location.pathname}#${headings[i].getAttribute('id')}`
+        })
+  
+        clipboard.on('success', function(e) {
+          tooltip.show()
+  
+          setTimeout(() => {
+            tooltip.hide()
+          }, 700)
+      
+          e.clearSelection()
+        })
+      }
     }
   }
 }