Skip to content

Commit 831178c

Browse files
authored
Merge pull request #4324 from segmentio/develop
Release 23.9.1
2 parents 9b51218 + 6447166 commit 831178c

File tree

38 files changed

+4398
-3397
lines changed

38 files changed

+4398
-3397
lines changed

.github/styles/Vocab/Docs/accept.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
(?:P|p)endo
1313
(?:P|p)odfile
1414
(?:P|p)ostgres
15+
(?:R|r)ealtime
1516
(?:R|r)emarketing
1617
(?:U|u)nlinks?\b
1718
(?:U|u)nmaps?\b

scripts/catalog_papi.js

Lines changed: 48 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -71,41 +71,56 @@ const getConnectionModes = (destination) => {
7171
server: false
7272
},
7373
}
74-
destination.components.forEach(component => {
75-
switch (component.type) {
76-
case 'IOS':
77-
connectionModes.device.mobile = true
78-
break
79-
case 'ANDROID':
80-
connectionModes.device.mobile = true
81-
break
82-
case 'BROWSER':
83-
if (destination.browserUnbundling) {
84-
connectionModes.cloud.web = true
85-
}
86-
connectionModes.device.web = true
87-
break
88-
case 'SERVER':
89-
connectionModes.cloud.mobile = true
90-
if (destination.platforms.server) {
91-
connectionModes.cloud.server = true
92-
}
93-
if (destination.platforms.browser) {
94-
connectionModes.cloud.web = true
95-
}
96-
break
97-
case 'CLOUD':
98-
connectionModes.cloud.mobile = true
99-
if (destination.platforms.server) {
100-
connectionModes.cloud.server = true
101-
}
102-
if (destination.platforms.browser) {
103-
connectionModes.cloud.web = true
104-
}
105-
break
10674

75+
// if destination has device specific components
76+
if (destination.components.length) {
77+
destination.components.forEach(component => {
78+
switch (component.type) {
79+
case 'IOS':
80+
connectionModes.device.mobile = true
81+
break
82+
case 'ANDROID':
83+
connectionModes.device.mobile = true
84+
break
85+
case 'BROWSER':
86+
if (destination.browserUnbundling) {
87+
connectionModes.cloud.web = true
88+
}
89+
connectionModes.device.web = true
90+
break
91+
case 'SERVER':
92+
connectionModes.cloud.mobile = true
93+
if (destination.platforms.server) {
94+
connectionModes.cloud.server = true
95+
}
96+
if (destination.platforms.browser) {
97+
connectionModes.cloud.web = true
98+
}
99+
break
100+
case 'CLOUD':
101+
connectionModes.cloud.mobile = true
102+
if (destination.platforms.server) {
103+
connectionModes.cloud.server = true
104+
}
105+
if (destination.platforms.browser) {
106+
connectionModes.cloud.web = true
107+
}
108+
break
109+
}
110+
})
111+
// if destination has no device specific components, check for supported platforms
112+
} else {
113+
if (destination.platforms.browser) {
114+
connectionModes.cloud.web = true
107115
}
108-
})
116+
if (destination.platforms.mobile) {
117+
connectionModes.cloud.mobile = true
118+
}
119+
if (destination.platforms.server) {
120+
connectionModes.cloud.server = true
121+
}
122+
}
123+
109124
return connectionModes
110125
}
111126

scripts/private-destination.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,18 @@ const getDestinationData = async (id) => {
7777
destination.supportedMethods.screen = true
7878
}
7979

80+
const clone = (obj) => Object.assign({}, obj)
81+
const renameKey = (object, key, newKey) => {
82+
const clonedObj = clone(object);
83+
const targetKey = clonedObj[key];
84+
delete clonedObj[key];
85+
86+
clonedObj[newKey] = targetKey;
87+
return clonedObj;
88+
};
89+
90+
destination.supportedMethods = renameKey(destination.supportedMethods, 'pageview', 'page')
91+
8092
let updatePrivateDest = {
8193
id: destination.id,
8294
display_name: destination.name,

src/_data/catalog/destination_categories.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# AUTOGENERATED FROM PUBLIC API. DO NOT EDIT
2-
# destination categories last updated 2023-02-23
2+
# destination categories last updated 2023-02-28
33
items:
44
- display_name: A/B Testing
55
slug: a-b-testing

0 commit comments

Comments
 (0)