Skip to content

Commit 84999e3

Browse files
committed
DOC-204 make settings into tables
1 parent d235b70 commit 84999e3

File tree

3 files changed

+27
-18
lines changed

3 files changed

+27
-18
lines changed

js/headings-anchors/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import ClipboardJS from 'clipboard'
22
import tippy from 'tippy.js'
33

44
const COMPONENT_SELECTOR = '[data-headings-anchors]'
5-
const HEADINGS_SELECTOR = 'h1, h2, h3, h4, h5'
5+
const HEADINGS_SELECTOR = 'h1, h2, h3, h4, h5, .def'
66

77
export default function () {
88
const components = document.querySelectorAll(COMPONENT_SELECTOR)

scripts/papi.js

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
// [x] Add dossier content
99
// [x] make quick info work
1010
// [x] why aren't hidden articles hiding?
11-
// [ ] fix slugify overrides?
12-
// [ ] fix settings sections
11+
// [x] fix slugify overrides?
12+
// [x] fix settings sections
1313

1414
// Notes
1515
// PAPI sources do not include type or categories
@@ -103,15 +103,15 @@ const getConnectionModes = (destination) => {
103103
connectionModes.cloud.web = true
104104
}
105105
break
106-
// case 'CLOUD':
107-
// connectionModes.cloud.mobile = true
108-
// if (destination.platforms.server) {
109-
// connectionModes.cloud.server = true
110-
// }
111-
// if (destination.platforms.browser) {
112-
// connectionModes.cloud.web = true
113-
// }
114-
// break
106+
case 'CLOUD':
107+
connectionModes.cloud.mobile = true
108+
if (destination.platforms.server) {
109+
connectionModes.cloud.server = true
110+
}
111+
if (destination.platforms.browser) {
112+
connectionModes.cloud.web = true
113+
}
114+
break
115115

116116
}
117117
})
@@ -206,8 +206,6 @@ const getConnectionModes = (destination) => {
206206
}
207207
}
208208
}
209-
210-
211209
return connectionModes
212210
}
213211

@@ -407,4 +405,4 @@ const updateDestinations = async () => {
407405
}
408406

409407
updateDestinations()
410-
//updateSources()
408+
updateSources()

src/_includes/content/destination-footer.md

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,26 @@ When you first create an audience, Personas sends an Identify call for every use
4444
## Settings
4545

4646
Segment lets you change these destination settings from the Segment app without having to touch any code.
47-
47+
<table>
48+
<tr>
49+
<th>Setting Name</th>
50+
<th>Data Type</th>
51+
<th>Default</th>
52+
<th>Description</th>
53+
</tr>
4854
{% for item in currentIntegration.settings %}
4955
{% unless item.deprecated == true %}
50-
### {{ item.display_name }}
56+
<tr>
57+
<td class="def" id="{{item.name | slugify}}" style="cursor:pointer">{{item.name}}</td>
58+
<td>{{item.type}}</td>
59+
<td>{{item.defaultValue}}</td>
60+
<td markdown="span">{{item.description}}</td>
61+
</tr>
5162

52-
{{ item.description }}
5363

5464
{% endunless %}
5565
{% endfor %}
66+
</table>
5667
{% endunless %}
5768
{% if currentIntegration.previous_names.size > 1 %}
5869

0 commit comments

Comments
 (0)