Skip to content

Commit 89ea1c0

Browse files
Apply suggestions from code review
1 parent 4729eca commit 89ea1c0

File tree

2 files changed

+17
-16
lines changed

2 files changed

+17
-16
lines changed

src/connections/sources/catalog/libraries/mobile/apple/destination-plugins/intercom-swift.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ analytics.group(groupId: "group123", traits: MyTraits(
193193
plan: "premium"))
194194
```
195195

196-
Segment supports Intercom companies in all sources. Users can be put into multiple groups, which associate them to multiple companies in Intercom.
196+
Segment supports Intercom `company` values sent from all source types. Users can be put into multiple groups, which associate them to multiple companies in Intercom.
197197

198198
When you call Group from any of any server-side libraries or mobile sources in cloud-mode (without Segment's mobile Intercom SDK installed), you must include either the `userId` or `email` of an existing user in Intercom.
199199

src/connections/sources/catalog/libraries/mobile/kotlin-android/destination-plugins/nielsen-dcr-kotlin-android.md

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -199,21 +199,6 @@ The Segment-Nielsen-DCR integration has logic to check for `type` in case of a p
199199

200200
#### Integration specific options
201201

202-
Example for Android:
203-
204-
```java
205-
Map<String, Object> nielsenOptions = new LinkedHashMap<>();
206-
nielsenOptions.put("pipmode", "c3 value");
207-
nielsenOptions.put("adLoadType", "c4 value");
208-
nielsenOptions.put("channelName", "c6 value");
209-
nielsenOptions.put("mediaUrl", "c6 value");
210-
nielsenOptions.put("hasAds", "true");
211-
nielsenOptions.put("crossId1", "cross id1 value");
212-
nielsenOptions.put("crossId2", "cross id2 value");
213-
214-
Analytics.with(context).track("Video Playback Started", new Properties(), new Options().setIntegrationOptions("nielsen-dcr", nielsenOptions));
215-
216-
```
217202

218203
#### Pipmode
219204

@@ -235,6 +220,22 @@ Standard episode ID.
235220

236221
Content originator ID. This value is only required for distributors.
237222

223+
Example for Android:
224+
225+
```java
226+
Map<String, Object> nielsenOptions = new LinkedHashMap<>();
227+
nielsenOptions.put("pipmode", "c3 value");
228+
nielsenOptions.put("adLoadType", "c4 value");
229+
nielsenOptions.put("channelName", "c6 value");
230+
nielsenOptions.put("mediaUrl", "c6 value");
231+
nielsenOptions.put("hasAds", "true");
232+
nielsenOptions.put("crossId1", "cross id1 value");
233+
nielsenOptions.put("crossId2", "cross id2 value");
234+
235+
Analytics.with(context).track("Video Playback Started", new Properties(), new Options().setIntegrationOptions("nielsen-dcr", nielsenOptions));
236+
237+
```
238+
238239
## FAQ
239240

240241
#### How do you determine App Name?

0 commit comments

Comments
 (0)