Skip to content

Commit af80d5e

Browse files
committed
Add suggestions from code review
1 parent 023c58f commit af80d5e

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

src/_includes/content/functions/errors-and-error-handling.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
Segment considers a function's execution successful if it finishes without error. You can also `throw` an error to create a failure on purpose. Use these errors to validate event data before processing it, to ensure the function works as expected.
44

5-
You can `throw` the following pre-defined error types to indicate that the function ran as expected, but that data was deliverable:
5+
You can `throw` the following pre-defined error types to indicate that the function ran as expected, but that data was not deliverable:
66

77
- `EventNotSupported`
88
- `InvalidEventPayload`
@@ -51,4 +51,3 @@ async function onTrack(event) {
5151
```
5252
If you don't supply a function for an event type, Segment throws an `EventNotSupported` error by default.
5353

54-
You can read more about [error handling](#destination-functions-logs-and-errors) below.

src/connections/functions/destination-functions.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ To change which event type the handler listens to, you can rename it to the name
8383

8484
{% include content/functions/errors-and-error-handling.md %}
8585

86+
You can read more about [error handling](#destination-functions-logs-and-errors) below.
87+
8688
### Runtime and dependencies
8789

8890
{% include content/functions/runtime.md %}

src/connections/functions/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@ Destination insert functions help you enrich your data with code before you send
4141
Use cases:
4242
- Implement custom logic and enrich data with third party sources
4343
- Transform outgoing data with advanced filtration and computation
44-
- Ensure data compliance by performing tokenisation, encryption, or decryption before sending data out
44+
- Ensure data compliance by performing tokenisation, encryption, or decryption before sending data downstream
4545

4646
To learn more, visit [destination insert functions](/docs/connections/functions/insert-functions).

src/connections/functions/insert-functions.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ To create an insert function from Segment's catalog:
3030

3131
1. Navigate to **Connections > Catalog > Functions** and click **New Function**.
3232
2. From the Select Type screen, select **Insert** and click **Next: Build Function**.
33-
3. Write your function code, and test it. Manually enter a sample event and click **Run** to test.
33+
3. Write and test your function code. Manually enter a sample event and click **Run** to test.
3434
4. Click **Next: Configure & Create** to add a function name, description, and logo.
3535
5. Click **Create Function** to create your insert function. You'll see the insert function displayed in the Functions tab.
3636

@@ -103,6 +103,8 @@ To change which event type the handler listens to, you can rename it to the name
103103

104104
{% include content/functions/errors-and-error-handling.md %}
105105

106+
You can read more about [error handling](#destination-insert-functions-logs-and-errors) below.
107+
106108
## Create settings and secrets
107109

108110
{% include content/functions/settings.md %}
@@ -174,7 +176,7 @@ Note the following limitations for batching with insert functions:
174176
- Max count begins with 100 and goes up to 1,000.
175177

176178
> info ""
177-
> Batching is available for insert and destination functions only. Read more about batching [here](/docs/connections/functions/destination-functions/#batching-the-destination-function).
179+
> Batching is available for insert and destination functions only. Read more about batching [in the Destination Functions docs](/docs/connections/functions/destination-functions/#batching-the-destination-function).
178180
179181
{% endcomment %}
180182

0 commit comments

Comments
 (0)