Merge branch 'master' into niall/amplitude_group_call

Author: niallzato

CODEOWNERS

@@ -1,12 +1,12 @@
 # The default owners for everything in
 # the repo. Unless a later match takes precedence.
-CODEOWNERS  @sanscontext @XavierAgostini @danielstjules @stephment
+CODEOWNERS  @sanscontext @markzegarelli @nielst @XavierAgostini @danielstjules @stephment
 
 # Diagram library
 /diagram-library @sanscontext
 
 # Utility scripts
-/scripts @sanscontext @XavierAgostini
+/scripts @sanscontext @bryanmikaelian @XavierAgostini
 
 
 # Content owners should be in the order of PM, TL (team-lead), and EM (in a crisis) for a given team.
@@ -20,10 +20,8 @@ CODEOWNERS  @sanscontext @XavierAgostini @danielstjules @stephment
 # Libraries owners
 /src/connections/catalog/libraries  @osamakhn @bsneed @lubird @pooyaj @juliofarah
 
-
 # Destination owners
 /src/connections/destinations  @n2parko @danielstjules @benhorowitz
-# temporary removal: @carlosmecha
 
 
 # Privacy owners

Gemfile.lock

@@ -55,7 +55,8 @@ GEM
       jekyll (>= 3.7, < 5.0)
     jekyll-watch (2.2.1)
       listen (~> 3.0)
-    kramdown (2.1.0)
+    kramdown (2.3.0)
+      rexml
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
     liquid (4.0.3)
@@ -75,6 +76,7 @@ GEM
     rb-fsevent (0.10.3)
     rb-inotify (0.10.0)
       ffi (~> 1.0)
+    rexml (3.2.4)
     rouge (3.13.0)
     ruby-enum (0.7.2)
       i18n

devguide.md

@@ -21,6 +21,17 @@ If using OSX:
   * Run server, `make dev`
   * Visit http://localhost:4000/docs/
 
+## Changing a DevCenter Destination's name
+
+Occasionally, a destination will change names. This shouldn't be too difficult to handle, but make sure you do the following:
+- Change the name of the file **to match destination's new slug**
+- Check in the Partner Portal that the name change has appropriately filled out the `previousNames` field. There should be two (or more if this has aliases/many name changes).
+- Add a `redirect_from` frontmatter item, with the url of the old doc. This funnels anyone arriving at the old page from a link outside the docs site to the page at the new name.
+- Run a `make catalog` to pick up the name change.
+- Run `make docs` and test that:
+  1. The page shows up correctly at the url you specified using the new slug.
+  2. The programmatic content appears (cmodes, settings, previous names)
+  3. The redirect from the old page URL works.
 
 
 ## Developer information
@@ -132,3 +143,5 @@ There is as also some manual testing scripts that can be run to validate the bui
 3. `tests/imageSizes/getImageSizes.js`: used to get the 10 largest images in the repo.
 
 4. `npx mdspell 'src/**/*.md' -r --en-us`: used to validate spelling in docs, needs to be configured to add Segment terms.
+
+5. Included is the [Hyperlink](https://www.npmjs.com/package/hyperlink) NPM module. Run `bundle install` to install that, plus the tap-spot plugin for pretty output. To check all links on the site, prior to build, run `yarn run hyperlink ./_site/index.html --canonicalroot https://segment.com/docs -i -r --skip 0.0.0.0 | yarn run tap-spot`. This module checks hyper links, images, and anchor tags to ensure that everything linked internally resolves to a location. **TODO**: Add support for external links.

package.json

@@ -39,6 +39,8 @@
     "ajv": "6.10.2",
     "clipboard": "^2.0.6",
     "dotenv": "8.2.0",
+    "hyperlink": "^4.5.2",
+    "tap-spot": "^1.1.1",
     "tippy.js": "^5.2.0",
     "typewriter": "7.0.1"
   }

src/_data/catalog/destination_categories.yml

@@ -1,5 +1,5 @@
 # AUTOGENERATED FROM PLATFORM API. DO NOT EDIT
-# destination categories last updated 2020-08-11 
+# destination categories last updated 2020-08-28 
 items:
 - display_name: Email Marketing
   slug: email-marketing