Skip to content

Commit b98baba

Browse files
stayseesongmarkzegarelli
andauthored
Apply suggestions from code review
[netlify-ignore] Co-authored-by: markzegarelli <[email protected]>
1 parent 44336e9 commit b98baba

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

src/connections/destinations/catalog/amazon-kinesis-firehose/index.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,9 +183,9 @@ If you have many sources using Kinesis that it's impractical to attach all of th
183183
To set this value for a single Secret ID:
184184
1. Go to the Kinesis Firehose destination settings from each of your Segment sources.
185185
2. Click **Secret ID** and enter your Workspace ID.
186-
* **NOTE:** For security purposes, Segment recommends you to use your Workspace ID as your Secret ID. If you’re currently using a Secret ID different from your Workspace ID, you’ll be susceptible to attacks. You can find your Workspace ID by going to: **Settings > Workspace Settings > ID**.
187-
3. Once all of your sources have been updated to use this value, find the IAM role you created for this destination in the AWS Console in **Services > IAM > Roles**.
188-
4. Click on the role and navigate to the **Trust Relationships** tab.
186+
* **NOTE:** For security purposes, Segment recommends you to use your Segment Workspace ID as your Secret ID. If you’re using a Secret ID different from your Workspace ID, you're susceptible to attacks. You can find your Workspace ID by going to: **Settings > Workspace Settings > ID** from the Segment dashboard.
187+
3. Once all of your sources are updated to use this value, find the IAM role you created for this destination in the AWS Console in **Services > IAM > Roles**.
188+
4. Select the role and navigate to the **Trust Relationships** tab.
189189
5. Click **Edit trust relationship**. You should see a snippet that looks something that looks like this:
190190

191191
```json
@@ -207,4 +207,4 @@ To set this value for a single Secret ID:
207207
]
208208
}
209209
```
210-
6. Replace your Source ID (found at "YOUR_SEGMENT_SOURCE_ID") with your Secret ID.
210+
6. Replace the value of `sts:ExternalId` ( "YOUR_SEGMENT_SOURCE_ID") with the Secret ID / Workspace ID value from the previous step.

src/connections/destinations/catalog/amazon-kinesis/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,4 +232,4 @@ If you have many sources using Kinesis that it's impractical to attach all of th
232232
]
233233
}
234234
```
235-
6. Replace your source ID (found at `"YOUR_SEGMENT_SOURCE_ID"`) with your Secret ID.
235+
6. Replace the value of `sts:ExternalId` (`"YOUR_SEGMENT_SOURCE_ID"`) with your Secret ID.

src/connections/destinations/catalog/amazon-lambda/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ There are two options for setting up the IAM policy and role:
5959

6060
Using CloudFormation minimizes the setup steps needed, and is Segment's recommended way to create your Lambda's policy and role. To use CloudFormation:
6161
1. Create the CloudFormation Template.
62-
1. Copy or download the [SegmentLambdaDestinationCFTemplate](https://github.com/segmentio/segment-lambda-recipes/blob/ead6c0f77deb38cea7ed486a7b98b47207796b5c/SegmentLambdaDestinationCFTemplate#L1) from the [segment-lambda-recipes](https://github.com/segmentio/segment-lambda-recipes) GitHub repo.
62+
1. Copy or download the [SegmentLambdaDestinationCFTemplate](https://github.com/segmentio/segment-lambda-recipes/blob/ead6c0f77deb38cea7ed486a7b98b47207796b5c/SegmentLambdaDestinationCFTemplate#L1){:target="_blank"} from the [segment-lambda-recipes](https://github.com/segmentio/segment-lambda-recipes){:target="_blank"} GitHub repo.
6363
2. Save the file with a name you like, but make sure it doesn't have a file extension.
6464
2. Create the CloudFormation stack.
6565
1. Within the AWS Console, navigate to **CloudFormation > Stacks**.
@@ -94,7 +94,7 @@ Using CloudFormation minimizes the setup steps needed, and is Segment's recommen
9494

9595
![](images/CloudFormationLambdaRole.png)
9696

97-
13. Click on the **Physical ID** of the role. You will be redirected to the summary page for the role within the IAM console.
97+
13. Click the **Physical ID** of the role. You will be redirected to the summary page for the role within the IAM console.
9898
14. Copy the **Role ARN** and copy it into the **Role Address** setting in your Segment Lambda destination settings.
9999

100100
Using the examples provided, your Segment Lambda destination settings will look something like this:

src/connections/destinations/catalog/amazon-personalize/index.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ There are a few pre-requisites before getting started. They are:
2222
3. Ability to deploy Lambda functions in Amazon Web Services
2323
4. Access to AWS Personalize
2424

25-
If you don't have an S3, Redshift warehouse, or Snowflake warehouse set up, you can read more about setting up [S3](https://segment.com/docs/connections/storage/catalog/amazon-s3/), [Redshift](https://segment.com/docs/connections/storage/catalog/redshift/), and [Snowflake](https://segment.com/docs/connections/storage/catalog/snowflake/).
25+
If you don't have S3, Redshift warehouse, or Snowflake warehouse configured, you can read more about setting up [S3](/docs/connections/storage/catalog/amazon-s3/), [Redshift](/docs/connections/storage/catalog/redshift/), and [Snowflake](/docs/connections/storage/catalog/snowflake/).
2626

2727
***If you're a Segment business tier customer, contact your Success contact to initiate a replay to S3 or your Warehouse.***
2828

@@ -645,7 +645,7 @@ In the next section, we will build a real-time clickstream ingestion pipeline th
645645

646646
## Getting Recommendations and Live Event Updates
647647

648-
Once you deploy your Personalize solution and enable a Campaign, your Lambda can consume event notifications from Segment and use the Solution and Campaign to react to events which will drive your business cases.
648+
Once you deploy your Personalize solution and enable a Campaign, your Lambda instance consumes event notifications from Segment and use the Solution and Campaign to react to events which drive your business cases.
649649

650650
The example code Segment provides below shows how to forward events to the Personalize Solution you deployed to keep your model updated. It then forwards an `identify` event back to Segment with the recommendations from your Solution.
651651

@@ -656,9 +656,9 @@ Segment will need to be able to call ("invoke") your Lambda in order to process
656656

657657
#### Create an IAM policy
658658
To create an IAM policy:
659-
1. Sign in to the [Identity and Access Management (IAM) console](https://console.aws.amazon.com/iam/) and follow these instructions to [Create an IAM policy](http://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_create.html) to allow Segment permission to invoke your Lambda function.
659+
1. Sign in to the [Identity and Access Management (IAM) console](https://console.aws.amazon.com/iam/){:target="_blank"} and follow these instructions to [Create an IAM policy](http://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_create.html){:target="_blank"} to allow Segment permission to invoke your Lambda function.
660660

661-
2. Select the **Create Policy from JSON** option and use the following template policy in the `Policy Document` field. Be sure to change the `{region}`, `{account-id}` and `{function-names}` with the applicable values. Here's example of a Lambda ARN `arn:aws:lambda:us-west-2:355207333203:function:``my-example-function`.
661+
2. Select **Create Policy from JSON** and use the following template policy in the `Policy Document` field. Be sure to change the `{region}`, `{account-id}` and `{function-names}` with the applicable values. Here's example of a Lambda ARN `arn:aws:lambda:us-west-2:355207333203:function:``my-example-function`.
662662

663663
> note ""
664664
> **NOTE:** You can put in a placeholder ARN for now, as you will need to come back to this step to update with the ARN of your Lambda once that's been created.
@@ -685,10 +685,10 @@ To create an IAM policy:
685685

686686
#### Create an IAM role
687687
To create an IAM role:
688-
1. Sign in to the [Identity and Access Management (IAM) console](https://console.aws.amazon.com/iam/) and follow these instructions to [Create an IAM role](http://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user.html#roles-creatingrole-user-console) to allow Segment permission to invoke your Lambda function.
688+
1. Sign in to the [Identity and Access Management (IAM) console](https://console.aws.amazon.com/iam/){:target="_blank"} and follow these instructions to [Create an IAM role](http://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user.html#roles-creatingrole-user-console){:target="_blank"} to allow Segment permission to invoke your Lambda function.
689689
2. While setting up the new role, add the policy you created in the [previous step](/docs/connections/destinations/catalog/amazon-personalize/#create-an-iam-policy).
690690
3. Finish with any other set up items you may want (like `tags`).
691-
4. Search for and click on your new roles from the [IAM home](https://console.aws.amazon.com/iam/home#/home).
691+
4. Search for and click on your new roles from the [IAM home](https://console.aws.amazon.com/iam/home#/home){:target="_blank"}.
692692
5. Select the **Trust Relationships** tab, then click **Edit trust relationship**.
693693

694694
![](images/LambdaTrustRelationship.png)
@@ -698,7 +698,7 @@ To create an IAM role:
698698
> note ""
699699
> **NOTE:** Your Source ID can be found by navigating to **Settings > API Keys** from your Segment source homepage.
700700
>
701-
> If you're using an External ID, for security purposes, Segment recommends you to use your Workspace ID as your External ID. If you’re currently using an External ID different from your Workspace ID, you’ll be susceptible to attacks. You can find your Workspace ID by going to: **Settings > Workspace Settings > ID**.
701+
> If you're using an External ID, for security purposes, Segment recommends you to use your Segment Workspace ID as your External ID. If you use an External ID different from your Workspace ID, you’re susceptible to attacks. You can find your Workspace ID by going to: **Settings > Workspace Settings > ID** in the Segment dashboard.
702702
703703
```json
704704
{

0 commit comments

Comments
 (0)