Skip to content

Commit d1cdad5

Browse files
Apply suggestions from code review [netlify-build]
Co-authored-by: rchinn-segment <[email protected]>
1 parent 9738165 commit d1cdad5

File tree

1 file changed

+9
-9
lines changed
  • src/connections/storage/catalog/aws-s3

1 file changed

+9
-9
lines changed

src/connections/storage/catalog/aws-s3/index.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -243,15 +243,15 @@ For example:
243243
For each source in the scenario, complete the steps described in [Migrate an existing destination](#migrate-an-existing-destination), and ensure that you have separate IAM Roles and Permissions set for staging and production use.
244244

245245
## Migrate an existing destination using the Public API
246-
This procedure uses Segment's Public API to migrate an existing Amazon S3 destination to the new AWS S3 destination. For more information about the Public API, see the [Public API documentation](https://api.segmentapis.com/docs/guides/#introduction).
246+
This procedure uses Segment's Public API to migrate an existing Amazon S3 destination to the new AWS S3 destination. For more information about the Public API, see the [Public API documentation](https://api.segmentapis.com/docs/guides/#introduction){:target="_blank"}.
247247

248248
> warning "Avoid overwriting data"
249249
> Sending data to the same S3 location from both the existing Amazon S3 destination and the AWS S3 destinations will overwrite data in your instance of S3. To avoid this, disable your Amazon S3 destination after you create your AWS S3 destination.
250250

251251
To migrate to the AWS S3 destination using the Public API:
252252

253253
1. Open the Segment app, select the Connections tab and then select Catalog.
254-
2. From the Catalog, select the Storage Destinations tab, and select the **AWS S3** destination.
254+
2. From the Catalog, select the Storage Destinations tab and select the **AWS S3** destination.
255255
3. On the AWS S3 destination page, click the **Configure AWS S3** button.
256256
4. Configure your AWS S3 destination. When asked for the bucket name, enter `<YOUR_BUCKET_NAME>/segment-logs/test`.
257257
5. Enable the destination, and verify data is received at `<YOUR_BUCKET_NAME>/segment-logs/test/segment-logs`. <br/>**Note:** If the folder receives data, continue to the next step. If you don't see log entries, check the trust relationship document and IAM policy attached to your IAM role.
@@ -268,7 +268,7 @@ To migrate to the AWS S3 destination using the Public API:
268268
}
269269
}
270270
```
271-
<br/>**Optional:** You can create a destination that is not enabled automatically upon creation by setting `enabled` to `false` when creating the new AWS S3 destination:
271+
<br/>**Optional:** You can create a destination that's not enabled automatically upon creation by setting `enabled` to `false` when creating the new AWS S3 destination:
272272
<br/>
273273
```shell
274274
curl -vvv --location --request PATCH https://api.segmentapis.com/destinations/$DESTINATION_ID \
@@ -298,7 +298,7 @@ curl -vvv --location --request GET https://api.segmentapis.com/destinations/$DES
298298
--data-raw '
299299
```
300300
301-
9. Disable the Amazon S3 destinations using the following command, replacing `$DESTINATION_ID` with the ID of your Amazon S3 destination you found in previous step:
301+
9. Disable the Amazon S3 destinations using the following command, replacing `$DESTINATION_ID` with the ID of your Amazon S3 destination you found in the previous step:
302302
303303
```shell
304304
curl -vvv --location --request PATCH https://api.segmentapis.com/destinations/$DESTINATION_ID \
@@ -316,7 +316,7 @@ curl -vvv --location --request PATCH https://api.segmentapis.com/destinations/$D
316316
> You must migrate to the new S3 destination before you disable your legacy destination to ensure Segment continues to deliver data to your S3 bucket.
317317
318318
## Test your migrated source
319-
You can validate that your configured your migrated source correctly on the AWS S3 destination page in the Segment app.
319+
You can validate that you configured your migrated source correctly on the AWS S3 destination page in the Segment app.
320320
321321
> note "Source editing permissions required"
322322
> In-app source validation is restricted to users with source editing permissions (for example, users with Workspace Owner, Source Admin, or Workspace Admin roles). For more information about roles in the Segment app, see the [Roles documentation](/docs/segment-app/iam/roles/).
@@ -338,10 +338,10 @@ The following table outlines some of the error codes the validation tool may dis
338338
| ------------- | ------------------------- |
339339
| Unknown Error. Please try again. If the problem persists, please contact [Segment support](mailto:[email protected]). | Fail to assume intermediate role |
340340
| Access Denied. Please configure External ID in the AWS IAM Console. [Learn more](#create-an-iam-role-in-the-aws-console). | Successfully assumed customer's role, role doesn't have external ID |
341-
| Unknown Error. Please follow [instructions](#create-an-iam-role-in-the-aws-console) to set up the AWS S3 destination. If the problem persists, please contact [Segment support](mailto:[email protected]). | Fail to assume customer’s role without external ID & returned an error code that is not error 403 |
342-
| Access Denied. Please configure External ID in the AWS IAM Console. [Learn more](#create-an-iam-role-in-the-aws-console). | Fail to assume customer’s role without external ID & returned error 403 |
343-
| Access Denied. Please add PutObject permissions to the IAM role in the AWS IAM Console. [Learn more](#create-an-iam-role-in-the-aws-console). | Fail to upload the dummy object to customer's S3 bucket & an error code that is not error 403. |
344-
| Unknown Error. Please follow [instructions](#create-an-iam-role-in-the-aws-console) to set up the AWS S3 destination. If the problem persists, please contact [Segment support](mailto:[email protected]). | Fail to upload the dummy object to customer's S3 bucket & an error code that is not error 403. |
341+
| Unknown Error. Please follow [instructions](#create-an-iam-role-in-the-aws-console) to set up the AWS S3 destination. If the problem persists, please contact [Segment support](mailto:[email protected]). | Fail to assume customer’s role without external ID and returned an error code that is not error 403 |
342+
| Access Denied. Please configure External ID in the AWS IAM Console. [Learn more](#create-an-iam-role-in-the-aws-console). | Fail to assume customer’s role without external ID and returned error 403 |
343+
| Access Denied. Please add PutObject permissions to the IAM role in the AWS IAM Console. [Learn more](#create-an-iam-role-in-the-aws-console). | Fail to upload the dummy object to customer's S3 bucket and an error code that is not error 403. |
344+
| Unknown Error. Please follow [instructions](#create-an-iam-role-in-the-aws-console) to set up the AWS S3 destination. If the problem persists, please contact [Segment support](mailto:[email protected]). | Fail to upload the dummy object to customer's S3 bucket and an error code that is not error 403. |
345345
346346
347347
## Data format

0 commit comments

Comments
 (0)