Skip to content

Commit 1e0a564

Browse files
committed
Move comment to right spot
1 parent e041cbb commit 1e0a564

File tree

4 files changed

+19
-3
lines changed

4 files changed

+19
-3
lines changed

docs/resources/destination_subscription.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,20 @@ resource "segment_destination_subscription" "send_to_webhook" {
7474
### Optional
7575

7676
- `model_id` (String) The unique identifier for the linked ReverseETLModel, if this part of a Reverse ETL connection.
77+
- `reverse_etl_schedule` (Attributes) (Reverse ETL only) The schedule for the subscription being attached to ReverseETL model. (see [below for nested schema](#nestedatt--reverse_etl_schedule))
7778

7879
### Read-Only
7980

8081
- `action_slug` (String) The URL-friendly key for the associated Destination action.
8182
- `id` (String) The unique identifier for the subscription.
83+
84+
<a id="nestedatt--reverse_etl_schedule"></a>
85+
### Nested Schema for `reverse_etl_schedule`
86+
87+
Required:
88+
89+
- `strategy` (String) Strategy supports three modes: PERIODIC, SPECIFIC_DAYS, or MANUAL.
90+
91+
Optional:
92+
93+
- `config` (String) Configures the schedule for the subscription.

docs/resources/reverse_etl_model.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,13 @@ resource "segment_reverse_etl_model" "example" {
6868
- `name` (String) A short, human-readable description of the Model.
6969
- `query` (String) The SQL query that will be executed to extract data from the connected Source.
7070
- `query_identifier_column` (String) Indicates the column named in `query` that should be used to uniquely identify the extracted records.
71-
- `schedule_config` (String) Depending on the chosen strategy, configures the schedule for this model.
72-
- `schedule_strategy` (String) Determines the strategy used for triggering syncs, which will be used in conjunction with scheduleConfig.
7371
- `source_id` (String) Indicates which Source to attach this model to.
7472

73+
### Optional
74+
75+
- `schedule_config` (String, Deprecated) Depending on the chosen strategy, configures the schedule for this model.
76+
- `schedule_strategy` (String, Deprecated) Determines the strategy used for triggering syncs, which will be used in conjunction with scheduleConfig.
77+
7578
### Read-Only
7679

7780
- `id` (String) The unique identifier for the model.

internal/provider/destination_resource_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ func TestAccDestinationResource(t *testing.T) {
138138
if req.Method == http.MethodPatch {
139139
updated++
140140
}
141-
// First update is in create to set the reverse etl model id
142141
if updated > 0 {
143142
payload = `{
144143
"data": {

internal/provider/destination_subscription_resource_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ func TestAccDestinationSubscriptionResource(t *testing.T) {
3636
}
3737
`
3838
} else if req.URL.Path == "/destinations/my-destination-id/subscriptions/my-subscription-id" && req.Method == http.MethodPatch {
39+
// First update is to set the model id
3940
if updated < 1 {
4041
payload = `
4142
{
@@ -78,6 +79,7 @@ func TestAccDestinationSubscriptionResource(t *testing.T) {
7879

7980
updated++
8081
} else if req.URL.Path == "/destinations/my-destination-id/subscriptions/my-subscription-id" && req.Method == http.MethodGet {
82+
// First update is to set the model id
8183
if updated <= 1 {
8284
payload = `
8385
{

0 commit comments

Comments
 (0)