Deprecate schedule in reverse etl model resource

Author: deanhuynh

go.mod

@@ -11,7 +11,7 @@ require (
 	github.com/hashicorp/terraform-plugin-framework-validators v0.13.0
 	github.com/hashicorp/terraform-plugin-go v0.24.0
 	github.com/hashicorp/terraform-plugin-testing v1.10.0
-	github.com/segmentio/public-api-sdk-go v0.0.0-20241017001201-fbbdab459db8
+	github.com/segmentio/public-api-sdk-go v0.0.0-20241025180535-501a23c07559
 	gotest.tools/gotestsum v1.12.0
 )
 

go.sum

@@ -189,6 +189,8 @@ github.com/segmentio/public-api-sdk-go v0.0.0-20240909200753-311bb8d791a2 h1:vlK
 github.com/segmentio/public-api-sdk-go v0.0.0-20240909200753-311bb8d791a2/go.mod h1:yKkoPfcOkkYjiZQj4lRWxji0Qwc6ncNEf7wCfywochY=
 github.com/segmentio/public-api-sdk-go v0.0.0-20241017001201-fbbdab459db8 h1:pYJu97HA0FVdy+WCqQbS/baDzXxg2q0Vl+akD6SUBSI=
 github.com/segmentio/public-api-sdk-go v0.0.0-20241017001201-fbbdab459db8/go.mod h1:yKkoPfcOkkYjiZQj4lRWxji0Qwc6ncNEf7wCfywochY=
+github.com/segmentio/public-api-sdk-go v0.0.0-20241025180535-501a23c07559 h1:6jgXPksz5bEJUMbhp4biSIViye/Os2yfAOx9yy44e1g=
+github.com/segmentio/public-api-sdk-go v0.0.0-20241025180535-501a23c07559/go.mod h1:yKkoPfcOkkYjiZQj4lRWxji0Qwc6ncNEf7wCfywochY=
 github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3 h1:n661drycOFuPLCN3Uc8sB6B/s6Z4t2xvBgU1htSHuq8=
 github.com/sergi/go-diff v1.3.2-0.20230802210424-5b0b94c5c0d3/go.mod h1:A0bzQcvG0E7Rwjx0REVgAGH58e96+X0MeOfepqsbeW4=
 github.com/shopspring/decimal v1.2.0/go.mod h1:DKyhrW/HYNuLGql+MJL6WCR6knT2jwCFRcu2hWCYk4o=

internal/provider/reverse_etl_model_resource.go

@@ -98,24 +98,13 @@ func (r *reverseETLModelResource) Create(ctx context.Context, req resource.Creat
 		return
 	}
 
-	var scheduleConfig map[string]interface{}
-	if !plan.ScheduleConfig.IsNull() && !plan.ScheduleConfig.IsUnknown() {
-		diags = plan.ScheduleConfig.Unmarshal(&scheduleConfig)
-		resp.Diagnostics.Append(diags...)
-		if resp.Diagnostics.HasError() {
-			return
-		}
-	}
-
 	out, body, err := r.client.ReverseETLAPI.CreateReverseEtlModel(r.authContext).CreateReverseEtlModelInput(api.CreateReverseEtlModelInput{
 		Name:                  plan.Name.ValueString(),
 		SourceId:              plan.SourceID.ValueString(),
 		Description:           plan.Description.ValueString(),
 		Enabled:               plan.Enabled.ValueBool(),
-		ScheduleStrategy:      plan.ScheduleStrategy.ValueString(),
 		Query:                 plan.Query.ValueString(),
 		QueryIdentifierColumn: plan.QueryIdentifierColumn.ValueString(),
-		ScheduleConfig:        scheduleConfig,
 	}).Execute()
 	if body != nil {
 		defer body.Body.Close()
@@ -150,6 +139,10 @@ func (r *reverseETLModelResource) Create(ctx context.Context, req resource.Creat
 	if resp.Diagnostics.HasError() {
 		return
 	}
+
+	// Since we deprecated these values, we just need to set them to the plan values so there are no errors
+	resp.State.SetAttribute(ctx, path.Root("schedule_config"), plan.ScheduleConfig)
+	resp.State.SetAttribute(ctx, path.Root("schedule_strategy"), plan.ScheduleStrategy)
 }
 
 func (r *reverseETLModelResource) Read(ctx context.Context, req resource.ReadRequest, resp *resource.ReadResponse) {
@@ -192,6 +185,14 @@ func (r *reverseETLModelResource) Read(ctx context.Context, req resource.ReadReq
 	if resp.Diagnostics.HasError() {
 		return
 	}
+
+	// Since we deprecated these values, we just need to set them to the plan values so there are no errors
+	if !previousState.ScheduleConfig.IsNull() && !previousState.ScheduleConfig.IsUnknown() {
+		resp.State.SetAttribute(ctx, path.Root("schedule_config"), previousState.ScheduleConfig)
+	}
+	if !previousState.ScheduleStrategy.IsNull() && !previousState.ScheduleStrategy.IsUnknown() {
+		resp.State.SetAttribute(ctx, path.Root("schedule_strategy"), previousState.ScheduleStrategy)
+	}
 }
 
 func (r *reverseETLModelResource) Update(ctx context.Context, req resource.UpdateRequest, resp *resource.UpdateResponse) {
@@ -209,19 +210,10 @@ func (r *reverseETLModelResource) Update(ctx context.Context, req resource.Updat
 		return
 	}
 
-	var scheduleConfig map[string]interface{}
-	diags = plan.ScheduleConfig.Unmarshal(&scheduleConfig)
-	resp.Diagnostics.Append(diags...)
-	if resp.Diagnostics.HasError() {
-		return
-	}
-
 	out, body, err := r.client.ReverseETLAPI.UpdateReverseEtlModel(r.authContext, state.ID.ValueString()).UpdateReverseEtlModelInput(api.UpdateReverseEtlModelInput{
 		Name:                  plan.Name.ValueStringPointer(),
 		Description:           plan.Description.ValueStringPointer(),
 		Enabled:               plan.Enabled.ValueBoolPointer(),
-		ScheduleStrategy:      plan.ScheduleStrategy.ValueStringPointer(),
-		ScheduleConfig:        scheduleConfig,
 		Query:                 plan.Query.ValueStringPointer(),
 		QueryIdentifierColumn: plan.QueryIdentifierColumn.ValueStringPointer(),
 	}).Execute()
@@ -252,6 +244,10 @@ func (r *reverseETLModelResource) Update(ctx context.Context, req resource.Updat
 	if resp.Diagnostics.HasError() {
 		return
 	}
+
+	// Since we deprecated these values, we just need to set them to the plan values so there are no errors
+	resp.State.SetAttribute(ctx, path.Root("schedule_config"), plan.ScheduleConfig)
+	resp.State.SetAttribute(ctx, path.Root("schedule_strategy"), plan.ScheduleStrategy)
 }
 
 func (r *reverseETLModelResource) Delete(ctx context.Context, req resource.DeleteRequest, resp *resource.DeleteResponse) {