Skip to content

Commit a74cf84

Browse files
committed
use base 10 constant
1 parent b6ebb0d commit a74cf84

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/matchers.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,7 @@ function semver(v1Str, operator, v2Str): boolean {
284284

285285
// parseSemver parses a semantic version string like "1.2.3" or "1.0" or "2"
286286
function parseSemver(version: string): SemverVersion {
287+
const DECIMAL_RADIX = 10
287288
const parts = version.split('.')
288289
if (parts.length === 0 || parts.length > 3) {
289290
throw new Error('invalid version format')
@@ -297,23 +298,23 @@ function parseSemver(version: string): SemverVersion {
297298

298299
// Parse major version
299300
if (parts.length >= 1) {
300-
v.major = parseInt(parts[0].trim(), 10)
301+
v.major = parseInt(parts[0].trim(), DECIMAL_RADIX)
301302
if (isNaN(v.major)) {
302303
throw new Error('invalid major version')
303304
}
304305
}
305306

306307
// Parse minor version (defaults to 0)
307308
if (parts.length >= 2) {
308-
v.minor = parseInt(parts[1].trim(), 10)
309+
v.minor = parseInt(parts[1].trim(), DECIMAL_RADIX)
309310
if (isNaN(v.minor)) {
310311
throw new Error('invalid minor version')
311312
}
312313
}
313314

314315
// Parse patch version (defaults to 0)
315316
if (parts.length >= 3) {
316-
v.patch = parseInt(parts[2].trim(), 10)
317+
v.patch = parseInt(parts[2].trim(), DECIMAL_RADIX)
317318
if (isNaN(v.patch)) {
318319
throw new Error('invalid patch version')
319320
}

0 commit comments

Comments
 (0)