Fixes various MSVC compiler warnings. (#1547)

* Fixed MSVC C4129

* Fixed MSVC C6262.

* Attempt to suppress MSVC C26444 in PTF_ASSERT_RAISES.

* Fixed MSVC C26817

* Fixed MSVC C6387

* Fixed MSVC C26478

* Fixed C28182

* Fixed C6297

* Fixes C6011

* Fixed C26439.

Author: Dimi1010

Examples/DnsSpoofing/main.cpp

@@ -6,6 +6,7 @@
  * address as the resolved IP. Then it's sent back on the network on the same interface
  */
 
+#include <stdexcept>
 #include <vector>
 #include <iostream>
 #include <algorithm>
@@ -205,11 +206,15 @@ void handleDnsRequest(pcpp::RawPacket* packet, pcpp::PcapLiveDevice* dev, void*
 		ip4Layer->setDstIPv4Address(srcIP.getIPv4());
 		ip4Layer->getIPv4Header()->ipId = 0;
 	}
-	else
+	else if (ip6Layer != nullptr)
 	{
 		ip6Layer->setSrcIPv6Address(ip6Layer->getDstIPv6Address());
 		ip6Layer->setDstIPv6Address(srcIP.getIPv6());
 	}
+	else
+	{
+		throw std::logic_error("IPLayer should be either IPv4Layer or IPv6Layer");
+	}
 
 	// reverse src and dst UDP ports
 	uint16_t srcPort = udpLayer->getUdpHeader()->portSrc;

Examples/IcmpFileTransfer/IcmpFileTransfer-pitcher.cpp

@@ -7,6 +7,7 @@
  */
 
 #include <stdlib.h>
+#include <stdexcept>
 #include <iostream>
 #include <fstream>
 #ifndef _MSC_VER
@@ -37,6 +38,10 @@ void usleep(__int64 usec)
 	ft.QuadPart = -(10 * usec);  // Convert to 100 nanosecond interval, negative value indicates relative time
 
 	timer = CreateWaitableTimer(NULL, TRUE, NULL);
+	if (timer == nullptr)
+	{
+		throw std::runtime_error("Could not create waitable timer with error: " + std::to_string(GetLastError()));
+	}
 	SetWaitableTimer(timer, &ft, 0, NULL, NULL, 0);
 	WaitForSingleObject(timer, INFINITE);
 	CloseHandle(timer);

Packet++/header/HttpLayer.h

@@ -710,13 +710,13 @@ namespace pcpp
 		class HttpRequestFirstLineException : public std::exception
 		{
 		public:
-			~HttpRequestFirstLineException() throw()
+			~HttpRequestFirstLineException() noexcept
 			{}
 			void setMessage(const std::string& message)
 			{
 				m_Message = message;
 			}
-			virtual const char* what() const throw()
+			virtual const char* what() const noexcept
 			{
 				return m_Message.c_str();
 			}
@@ -857,13 +857,13 @@ namespace pcpp
 		class HttpResponseFirstLineException : public std::exception
 		{
 		public:
-			~HttpResponseFirstLineException() throw()
+			~HttpResponseFirstLineException() noexcept
 			{}
 			void setMessage(const std::string& message)
 			{
 				m_Message = message;
 			}
-			virtual const char* what() const throw()
+			virtual const char* what() const noexcept
 			{
 				return m_Message.c_str();
 			}

Packet++/header/SipLayer.h

@@ -614,13 +614,13 @@ namespace pcpp
 		class SipRequestFirstLineException : public std::exception
 		{
 		public:
-			~SipRequestFirstLineException() throw()
+			~SipRequestFirstLineException() noexcept
 			{}
 			void setMessage(const std::string& message)
 			{
 				m_Message = message;
 			}
-			virtual const char* what() const throw()
+			virtual const char* what() const noexcept
 			{
 				return m_Message.c_str();
 			}
@@ -748,13 +748,13 @@ namespace pcpp
 		class SipResponseFirstLineException : public std::exception
 		{
 		public:
-			~SipResponseFirstLineException() throw()
+			~SipResponseFirstLineException() noexcept
 			{}
 			void setMessage(const std::string& message)
 			{
 				m_Message = message;
 			}
-			virtual const char* what() const throw()
+			virtual const char* what() const noexcept
 			{
 				return m_Message.c_str();
 			}

Packet++/src/FtpLayer.cpp

@@ -17,7 +17,9 @@ namespace pcpp
 		std::string field = getCommandString();
 
 		for (size_t idx = 0; idx < field.size(); ++idx)
-			val |= (field.c_str()[idx] << (idx * 8));
+		{
+			val |= static_cast<size_t>(field.c_str()[idx]) << (idx * 8);
+		}
 
 		return static_cast<FtpCommand>(val);
 	}

Packet++/src/IPv6Layer.cpp

@@ -1,5 +1,6 @@
 #define LOG_MODULE PacketLogModuleIPv6Layer
 
+#include <stdexcept>
 #include "IPv6Layer.h"
 #include "IPv4Layer.h"
 #include "PayloadLayer.h"
@@ -133,6 +134,10 @@ namespace pcpp
 			}
 			else
 			{
+				if (curExt == nullptr)
+				{
+					throw std::logic_error("curExt is nullptr");
+				}
 				curExt->setNextHeader(newExt);
 				curExt = curExt->getNextHeader();
 			}

Packet++/src/SipLayer.cpp

@@ -360,7 +360,7 @@ namespace pcpp
 	SipRequestLayer::SipRequestLayer(SipMethod method, const std::string& requestUri, const std::string& version)
 	{
 		m_Protocol = SIPRequest;
-		m_FirstLine = new SipRequestFirstLine(this, method, std::move(version), std::move(requestUri));
+		m_FirstLine = new SipRequestFirstLine(this, method, version, requestUri);
 		m_FieldsOffset = m_FirstLine->getSize();
 	}
 
@@ -598,7 +598,7 @@ namespace pcpp
 	                                   const std::string& sipVersion)
 	{
 		m_Protocol = SIPResponse;
-		m_FirstLine = new SipResponseFirstLine(this, std::move(sipVersion), statusCode, std::move(statusCodeString));
+		m_FirstLine = new SipResponseFirstLine(this, sipVersion, statusCode, std::move(statusCodeString));
 		m_FieldsOffset = m_FirstLine->getSize();
 	}
 

Packet++/src/SmtpLayer.cpp

@@ -18,7 +18,9 @@ namespace pcpp
 		std::string field = getCommandString();
 
 		for (size_t idx = 0; idx < field.size(); ++idx)
-			val |= (field.c_str()[idx] << (idx * 8));
+		{
+			val |= static_cast<size_t>(field.c_str()[idx]) << (idx * 8);
+		}
 
 		return static_cast<SmtpCommand>(val);
 	}

Packet++/src/TextBasedProtocol.cpp

@@ -529,7 +529,7 @@ namespace pcpp
 	{
 		m_NameValueSeparator = nameValueSeparator;
 		m_SpacesAllowedBetweenNameAndValue = spacesAllowedBetweenNameAndValue;
-		initNewField(std::move(name), std::move(value));
+		initNewField(name, value);
 	}
 
 	void HeaderField::initNewField(const std::string& name, const std::string& value)

Packet++/src/VrrpLayer.cpp

@@ -251,7 +251,7 @@ namespace pcpp
 
 		size_t ipAddrOffset = 0;
 		uint8_t* newIpAddresses = getData() + offset;
-		for (auto ipAddress : ipAddresses)
+		for (auto const& ipAddress : ipAddresses)
 		{
 			copyIPAddressToData(newIpAddresses + ipAddrOffset, ipAddress);
 			ipAddrOffset += ipAddrLen;