Moved SnoopFileReaderDevice to the bottom of the file. (#1956)

Author: Dimi1010

Pcap++/header/PcapFileDevice.h

@@ -275,79 +275,6 @@ namespace pcpp
 		bool openAppend();
 	};
 
-	/// @class SnoopFileReaderDevice
-	/// A class for opening a snoop file in read-only mode. This class enable to open the file and read all packets,
-	/// packet-by-packet
-	class SnoopFileReaderDevice : public IFileReaderDevice
-	{
-	private:
-#pragma pack(1)
-		/// File format header.
-		typedef struct
-		{
-			uint64_t identification_pattern;
-			uint32_t version_number;
-			uint32_t datalink_type;
-		} snoop_file_header_t;
-
-		/// Packet record header.
-		typedef struct
-		{
-			uint32_t original_length;       ///< original packet length
-			uint32_t included_length;       ///< saved packet length
-			uint32_t packet_record_length;  ///< total record length
-			uint32_t ndrops_cumulative;     ///< cumulative drops
-			uint32_t time_sec;              ///< timestamp
-			uint32_t time_usec;             ///< microsecond timestamp
-		} snoop_packet_header_t;
-#pragma pack()
-
-		LinkLayerType m_PcapLinkLayerType;
-		std::ifstream m_snoopFile;
-
-		// private copy c'tor
-		SnoopFileReaderDevice(const PcapFileReaderDevice& other);
-		SnoopFileReaderDevice& operator=(const PcapFileReaderDevice& other);
-
-	public:
-		/// A constructor for this class that gets the snoop full path file name to open. Notice that after calling this
-		/// constructor the file isn't opened yet, so reading packets will fail. For opening the file call open()
-		/// @param[in] fileName The full path of the file to read
-		SnoopFileReaderDevice(const std::string& fileName)
-		    : IFileReaderDevice(fileName), m_PcapLinkLayerType(LINKTYPE_ETHERNET)
-		{}
-
-		/// A destructor for this class
-		virtual ~SnoopFileReaderDevice();
-
-		/// @return The link layer type of this file
-		LinkLayerType getLinkLayerType() const
-		{
-			return m_PcapLinkLayerType;
-		}
-
-		// overridden methods
-
-		/// Read the next packet from the file. Before using this method please verify the file is opened using open()
-		/// @param[out] rawPacket A reference for an empty RawPacket where the packet will be written
-		/// @return True if a packet was read successfully. False will be returned if the file isn't opened (also, an
-		/// error log will be printed) or if reached end-of-file
-		bool getNextPacket(RawPacket& rawPacket);
-
-		/// Open the file name which path was specified in the constructor in a read-only mode
-		/// @return True if file was opened successfully or if file is already opened. False if opening the file failed
-		/// for some reason (for example: file path does not exist)
-		bool open();
-
-		/// Get statistics of packets read so far. In the PcapStats struct, only the packetsRecv member is relevant. The
-		/// rest of the members will contain 0
-		/// @param[out] stats The stats struct where stats are returned
-		void getStatistics(PcapStats& stats) const;
-
-		/// Close the snoop file
-		void close();
-	};
-
 	/// @class PcapNgFileReaderDevice
 	/// A class for opening a pcap-ng file in read-only mode. This class enable to open the file and read all packets,
 	/// packet-by-packet
@@ -559,4 +486,76 @@ namespace pcpp
 		bool openAppend();
 	};
 
+	/// @class SnoopFileReaderDevice
+	/// A class for opening a snoop file in read-only mode. This class enable to open the file and read all packets,
+	/// packet-by-packet
+	class SnoopFileReaderDevice : public IFileReaderDevice
+	{
+	private:
+#pragma pack(1)
+		/// File format header.
+		typedef struct
+		{
+			uint64_t identification_pattern;
+			uint32_t version_number;
+			uint32_t datalink_type;
+		} snoop_file_header_t;
+
+		/// Packet record header.
+		typedef struct
+		{
+			uint32_t original_length;       ///< original packet length
+			uint32_t included_length;       ///< saved packet length
+			uint32_t packet_record_length;  ///< total record length
+			uint32_t ndrops_cumulative;     ///< cumulative drops
+			uint32_t time_sec;              ///< timestamp
+			uint32_t time_usec;             ///< microsecond timestamp
+		} snoop_packet_header_t;
+#pragma pack()
+
+		LinkLayerType m_PcapLinkLayerType;
+		std::ifstream m_snoopFile;
+
+		// private copy c'tor
+		SnoopFileReaderDevice(const PcapFileReaderDevice& other);
+		SnoopFileReaderDevice& operator=(const PcapFileReaderDevice& other);
+
+	public:
+		/// A constructor for this class that gets the snoop full path file name to open. Notice that after calling this
+		/// constructor the file isn't opened yet, so reading packets will fail. For opening the file call open()
+		/// @param[in] fileName The full path of the file to read
+		SnoopFileReaderDevice(const std::string& fileName)
+		    : IFileReaderDevice(fileName), m_PcapLinkLayerType(LINKTYPE_ETHERNET)
+		{}
+
+		/// A destructor for this class
+		virtual ~SnoopFileReaderDevice();
+
+		/// @return The link layer type of this file
+		LinkLayerType getLinkLayerType() const
+		{
+			return m_PcapLinkLayerType;
+		}
+
+		// overridden methods
+
+		/// Read the next packet from the file. Before using this method please verify the file is opened using open()
+		/// @param[out] rawPacket A reference for an empty RawPacket where the packet will be written
+		/// @return True if a packet was read successfully. False will be returned if the file isn't opened (also, an
+		/// error log will be printed) or if reached end-of-file
+		bool getNextPacket(RawPacket& rawPacket);
+
+		/// Open the file name which path was specified in the constructor in a read-only mode
+		/// @return True if file was opened successfully or if file is already opened. False if opening the file failed
+		/// for some reason (for example: file path does not exist)
+		bool open();
+
+		/// Get statistics of packets read so far. In the PcapStats struct, only the packetsRecv member is relevant. The
+		/// rest of the members will contain 0
+		/// @param[out] stats The stats struct where stats are returned
+		void getStatistics(PcapStats& stats) const;
+
+		/// Close the snoop file
+		void close();
+	};
 }  // namespace pcpp