Add check to ensure offsetInLayer is not negative in Layer::extend/shorten

danasana · danasana · commit 936c316b5500 · 2025-09-10T17:09:01.000+03:00
diff --git a/Packet++/src/Layer.cpp b/Packet++/src/Layer.cpp
@@ -61,6 +61,12 @@ namespace pcpp
 			return false;
 		}
 
+		if (offsetInLayer < 0)
+		{
+			PCPP_LOG_ERROR("Requested offset is negative");
+			return false;
+		}
+
 		if (static_cast<size_t>(offsetInLayer) > m_DataLen)
 		{
 			PCPP_LOG_ERROR("Requested offset is larger than data length");
@@ -102,6 +108,12 @@ namespace pcpp
 			return false;
 		}
 
+		if (offsetInLayer < 0)
+		{
+			PCPP_LOG_ERROR("Requested offset is negative");
+			return false;
+		}
+
 		if (static_cast<size_t>(offsetInLayer) >= m_DataLen)
 		{
 			PCPP_LOG_ERROR("Requested offset is larger than data length");

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,12 @@ namespace pcpp`
`61`	`61`	`return false;`
`62`	`62`	`}`
`63`	`63`
	`64`	`+ if (offsetInLayer < 0)`
	`65`	`+ {`
	`66`	`+ PCPP_LOG_ERROR("Requested offset is negative");`
	`67`	`+ return false;`
	`68`	`+ }`
	`69`	`+`
`64`	`70`	`if (static_cast<size_t>(offsetInLayer) > m_DataLen)`
`65`	`71`	`{`
`66`	`72`	`PCPP_LOG_ERROR("Requested offset is larger than data length");`
`@@ -102,6 +108,12 @@ namespace pcpp`
`102`	`108`	`return false;`
`103`	`109`	`}`
`104`	`110`
	`111`	`+ if (offsetInLayer < 0)`
	`112`	`+ {`
	`113`	`+ PCPP_LOG_ERROR("Requested offset is negative");`
	`114`	`+ return false;`
	`115`	`+ }`
	`116`	`+`
`105`	`117`	`if (static_cast<size_t>(offsetInLayer) >= m_DataLen)`
`106`	`118`	`{`
`107`	`119`	`PCPP_LOG_ERROR("Requested offset is larger than data length");`