Fix inclusive parseUntil condition in the main packet parse loop.
#1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `parseUntil` is now fully inclusive and parses until it exhausts a sequence of target protocol types. This is to allow parsing until recursive layers that are followed by a layer of the same type. - Readability improvements.
Dimi1010
changed the title
parseUntil condition the main packet parse loop.
Dimi1010
changed the title
parseUntil condition the main packet parse loop.parseUntil condition in the main packet parse loop.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1964 +/- ##
==========================================
- Coverage 83.48% 83.45% -0.04%
==========================================
Files 311 311
Lines 54885 54920 +35
Branches 12218 12220 +2
==========================================
+ Hits 45822 45834 +12
+ Misses 7847 7819 -28
- Partials 1216 1267 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Dimi1010
commented
Sep 12, 2025
seladb
reviewed
Sep 19, 2025
This is so resource data can be generated easily for test creation. By default all ResourceProvider objects are created as frozen, and attempting to save to them will throw an exception.
Dimi1010
commented
Sep 21, 2025
seladb
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
Let's remove the commented-out code before merging: #1964 (comment)
Otherwise, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
parseUntilis now fully inclusive and parses until it exhausts a sequence of target protocol types. This allows specifying target protocols that allow chaining of the same protocol types.Simplified the rollback mechanism.