BF: not counting all 0s as NAs for coverage

jonathan-taylor · jonathan-taylor · commit 1fa2e7b2e2fa · 2018-10-17T12:51:13.000-07:00
diff --git a/selectiveInference/R/funs.ROSI.R b/selectiveInference/R/funs.ROSI.R
@@ -533,13 +533,15 @@ compute_coverage = function(ci, beta){
   print(ci)
   print(beta) 
   nactive=length(beta)
-  coverage_vector = rep(NA, nactive)
+  coverage_vector = rep(0, nactive)
   for (i in 1:nactive){
   if(!is.na(ci[i,1]) & !is.na(ci[i,2])) {
     if (beta[i]>=ci[i,1] && beta[i]<=ci[i,2]){
       coverage_vector[i]=1
     } 
-  }
+  } else {
+    coverage_vector[i] = NA
+    }
   }
   return(coverage_vector)
 }

Original file line number	Diff line number	Diff line change
`@@ -533,13 +533,15 @@ compute_coverage = function(ci, beta){`
`533`	`533`	`print(ci)`
`534`	`534`	`print(beta)`
`535`	`535`	`nactive=length(beta)`
`536`		`- coverage_vector = rep(NA, nactive)`
	`536`	`+ coverage_vector = rep(0, nactive)`
`537`	`537`	`for (i in 1:nactive){`
`538`	`538`	`if(!is.na(ci[i,1]) & !is.na(ci[i,2])) {`
`539`	`539`	`if (beta[i]>=ci[i,1] && beta[i]<=ci[i,2]){`
`540`	`540`	`coverage_vector[i]=1`
`541`	`541`	`}`
`542`		`- }`
	`542`	`+ } else {`
	`543`	`+ coverage_vector[i] = NA`
	`544`	`+ }`
`543`	`545`	`}`
`544`	`546`	`return(coverage_vector)`
`545`	`547`	`}`