Skip to content

Commit 80db795

Browse files
committed
rob bug from quanzao
1 parent 0bc3004 commit 80db795

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

selectiveInference/DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: selectiveInference
22
Type: Package
33
Title: Tools for Post-Selection Inference
4-
Version: 1.2.1
4+
Version: 1.2.2
55
Date: 2016-07-3
66
Author: Ryan Tibshirani, Rob Tibshirani, Jonathan Taylor,
77
Joshua Loftus, Stephen Reid

selectiveInference/R/funs.fixed.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ function(x, y, beta, lambda, a) {
158158
if (length(za)>1) dz = diag(za)
159159
if (length(za)==1) dz = matrix(za,1,1)
160160

161-
P = diag(1,nrow(xa)) - xa %*% xap
161+
# P = diag(1,nrow(xa)) - xa %*% xap
162162
#NOTE: inactive constraints not needed below!
163163

164164
G = -rbind(

selectiveInference/R/funs.fixedLogit.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ fixedLogitLassoInf=function(x,y,beta,lambda,alpha=.1, type=c("partial"), tol.bet
4545

4646
#check KKT
4747
z=etahat+(y-prhat)/ww
48-
# g= t(x)%*%w%*%(z-etahat)/lambda # negative gradient scaled by lambda
49-
gg=scale(t(x),FALSE,1/ww)%*%(z-etahat)/lambda # negative gradient scaled by lambda
48+
# g= t(x)%*%w%*%(z-etahat)/lambda # negative gradient scaled by lambda
49+
g=scale(t(x),FALSE,1/ww)%*%(z-etahat)/lambda # negative gradient scaled by lambda
5050
if (any(abs(g) > 1+tol.kkt) )
5151
warning(paste("Solution beta does not satisfy the KKT conditions",
5252
"(to within specified tolerances)"))

selectiveInference/src/symbols.rds

0 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)