Fixed handling of numeric variables in factorDesign #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es now OK on Rcmd check
Merge branch 'jelena-markovic-randomized_jelena_highdim'
beta version of randomized LASSO
Some bug fixes of randomizedLasso, most of framework for randomized logistic
joftius
approved these changes
Apr 9, 2018
jonathan-taylor
force-pushed
the
master
branch
from
bf1fa5e to
744ad87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
factorDesign assumed numeric variables preceded all factor variables, which may cause incorrect name assignment.
Also, fixed handling of multiple numeric variables (indcounter and assignment of numeric data.frame into the x matrix)
Thank you!
(This is my first pull request and real use of git: I hope I have completed it appropriately. Thank you for your understanding!)