Rename factories to converter

Author: odan

src/Factory/CakeValidatorFactory.php src/Converter/CakeValidationConverter.phpsrc/Factory/CakeValidatorFactory.php renamed to src/Converter/CakeValidationConverter.php

@@ -1,13 +1,13 @@
 <?php
 
-namespace Selective\Validation\Factory;
+namespace Selective\Validation\Converter;
 
 use Selective\Validation\ValidationResult;
 
 /**
- * CakePHP validation error collector.
+ * CakePHP validation error convert.
  */
-final class CakeValidatorFactory
+final class CakeValidationConverter
 {
     /**
      * Create validation result from array with errors.
@@ -31,8 +31,6 @@ public static function createValidationResult(array $errors): ValidationResult
      * @param ValidationResult $result The result
      * @param array<mixed> $errors The errors
      * @param string $path The path
-     *
-     * @return void
      */
     private static function addErrors(ValidationResult $result, array $errors, string $path = ''): void
     {

src/Factory/SymfonyValidatorFactory.php …Converter/SymfonyValidationConverter.phpsrc/Factory/SymfonyValidatorFactory.php renamed to src/Converter/SymfonyValidationConverter.php src/Factory/SymfonyValidatorFactory.php renamed to src/Converter/SymfonyValidationConverter.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Selective\Validation\Factory;
+namespace Selective\Validation\Converter;
 
 use Selective\Validation\ValidationResult;
 use Symfony\Component\Validator\ConstraintViolation;
@@ -9,7 +9,7 @@
 /**
  * Symfony validation error collector.
  */
-final class SymfonyValidatorFactory
+final class SymfonyValidationConverter
 {
     /**
      * Create validation result from array with errors.

…ts/Factory/CakeValidationFactoryTest.php …/Converter/CakeValidationFactoryTest.phptests/Factory/CakeValidationFactoryTest.php renamed to tests/Converter/CakeValidationFactoryTest.php tests/Factory/CakeValidationFactoryTest.php renamed to tests/Converter/CakeValidationFactoryTest.php

@@ -1,9 +1,9 @@
 <?php
 
-namespace Selective\Validation\Test\Factory;
+namespace Selective\Validation\Test\Converter;
 
 use PHPUnit\Framework\TestCase;
-use Selective\Validation\Factory\CakeValidatorFactory;
+use Selective\Validation\Converter\CakeValidationConverter;
 use Selective\Validation\Transformer\ErrorDetailsResultTransformer;
 use Selective\Validation\ValidationResult;
 
@@ -31,7 +31,7 @@ private function getValidationResultAsArray(ValidationResult $validationResult):
      */
     public function testCreateResultFromErrorsSimple()
     {
-        $result = CakeValidatorFactory::createValidationResult([
+        $result = CakeValidationConverter::createValidationResult([
             'first_name' => [
                 '_empty' => 'This field cannot be left empty',
             ],
@@ -104,7 +104,7 @@ public function testCreateResultFromErrorsSimple()
      */
     public function testCreateResultFromErrorsNestedArray()
     {
-        $result = CakeValidatorFactory::createValidationResult([
+        $result = CakeValidationConverter::createValidationResult([
             'bills' => [
                 0 => [
                     'billing_number' => [

tests/Converter/SymfonyValidationConverterTest.php

@@ -0,0 +1,30 @@
+<?php
+
+namespace Selective\Validation\Test\Converter;
+
+use PHPUnit\Framework\TestCase;
+use Selective\Validation\Converter\SymfonyValidationConverter;
+use Symfony\Component\Validator\ConstraintViolation;
+use Symfony\Component\Validator\ConstraintViolationList;
+
+/**
+ * Tests.
+ */
+class SymfonyValidationConverterTest extends TestCase
+{
+    /**
+     * Test.
+     */
+    public function testCreateValidationResult(): void
+    {
+        $violations = new ConstraintViolationList();
+        $violations->add(new ConstraintViolation('Email required', null, [], '', 'email', ''));
+
+        $result = SymfonyValidationConverter::createValidationResult($violations);
+
+        $this->assertEquals(true, $result->isFailed());
+        $this->assertEquals('Email required', $result->getErrors()[0]->getMessage());
+        $this->assertEquals('email', $result->getErrors()[0]->getField());
+        $this->assertEquals(null, $result->getErrors()[0]->getCode());
+    }
+}