Rename isFailed to fails and isSuccess to success

Author: odan

README.md

@@ -89,7 +89,7 @@ if (empty($data['password'])) {
 }
 
 // Check validation result
-if ($validation->isFailed()) {
+if ($validation->fails()) {
     // Trigger error response (see validation middleware)
     throw new ValidationException('Please check your input', $validation);
 }
@@ -210,7 +210,7 @@ if (empty($data->username)) {
 }
 
 // Check validation result
-if ($validation->isFailed()) {
+if ($validation->fails()) {
     // Trigger the validation middleware
     throw new ValidationException('Please check your input', $validation);
 }
@@ -341,7 +341,7 @@ if ($this->existsUsername($formData['username'])) {
     $validationResult->addError('username', 'Username is already taken');
 }
 
-if ($validationResult->isFailed()) {
+if ($validationResult->fails()) {
     throw new ValidationException(__('Please check your input'), $validationResult);
 }
 ```

src/ValidationResult.php

@@ -39,11 +39,11 @@ public function getFirstError(): ?ValidationError
     }
 
     /**
-     * Returns the success of the validation.
+     * Determine if the data passes the validation rules.
      *
      * @return bool true if validation was successful; otherwise, false
      */
-    public function isSuccess(): bool
+    public function success(): bool
     {
         return empty($this->errors);
     }
@@ -53,9 +53,9 @@ public function isSuccess(): bool
      *
      * @return bool Status
      */
-    public function isFailed(): bool
+    public function fails(): bool
     {
-        return !$this->isSuccess();
+        return !$this->success();
     }
 
     /**

tests/Converter/SymfonyValidationConverterTest.php

@@ -22,7 +22,7 @@ public function testCreateValidationResult(): void
 
         $result = SymfonyValidationConverter::createValidationResult($violations);
 
-        $this->assertEquals(true, $result->isFailed());
+        $this->assertEquals(true, $result->fails());
         $this->assertEquals('Email required', $result->getErrors()[0]->getMessage());
         $this->assertEquals('email', $result->getErrors()[0]->getField());
         $this->assertEquals(null, $result->getErrors()[0]->getCode());

tests/TestService.php

@@ -27,7 +27,7 @@ public function process(int $id): array
             $validation->addError('id', 'invalid');
         }
 
-        if ($validation->isFailed()) {
+        if ($validation->fails()) {
             throw new ValidationException('Please check your input', $validation);
         }
 

tests/ValidationResultTest.php

@@ -30,7 +30,7 @@ public function testErrors(): void
     {
         $val = new ValidationResult();
         $val->addError('error1', 'failed');
-        $result = $val->isFailed();
+        $result = $val->fails();
         $this->assertTrue($result);
     }
 
@@ -42,7 +42,7 @@ public function testErrorsEmptyFieldOne(): void
     {
         $val = new ValidationResult();
         $val->addError('', 'invalid');
-        $result = $val->isFailed();
+        $result = $val->fails();
         $this->assertTrue($result);
     }
 
@@ -54,7 +54,7 @@ public function testErrorsWithField(): void
     {
         $val = new ValidationResult();
         $val->addError('field', 'message');
-        $result = $val->isFailed();
+        $result = $val->fails();
         $this->assertTrue($result);
     }
 
@@ -66,7 +66,7 @@ public function testErrorsWithMessage(): void
     {
         $val = new ValidationResult();
         $val->addError('email', 'required', '5000');
-        $result = $val->isFailed();
+        $result = $val->fails();
         $this->assertTrue($result);
 
         $firstError = $val->getFirstError();
@@ -83,7 +83,7 @@ public function testErrorsWithMessage(): void
     public function testNoErrors(): void
     {
         $val = new ValidationResult();
-        $result = $val->isFailed();
+        $result = $val->fails();
         $this->assertFalse($result);
     }
 
@@ -95,7 +95,7 @@ public function testClear(): void
         $val = new ValidationResult();
         $val->addError('email', 'required');
         $val->clear();
-        $result = $val->isFailed();
+        $result = $val->fails();
         $this->assertFalse($result);
     }