Skip to content

Commit 06ec7eb

Browse files
committed
Update Chrome options when running remotely
1 parent f3c0151 commit 06ec7eb

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

seleniumbase/core/browser_launcher.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,8 @@ def _add_chrome_disable_csp_extension(chrome_options):
125125
def _set_chrome_options(
126126
downloads_path, headless, proxy_string, proxy_auth,
127127
proxy_user, proxy_pass, user_agent, disable_csp, enable_sync,
128-
user_data_dir, extension_zip, extension_dir, mobile_emulator,
129-
device_width, device_height, device_pixel_ratio):
128+
user_data_dir, extension_zip, extension_dir, servername,
129+
mobile_emulator, device_width, device_height, device_pixel_ratio):
130130
chrome_options = webdriver.ChromeOptions()
131131
prefs = {
132132
"download.default_directory": downloads_path,
@@ -140,7 +140,8 @@ def _set_chrome_options(
140140
chrome_options.add_experimental_option("w3c", True)
141141
chrome_options.add_experimental_option(
142142
"excludeSwitches", ["enable-automation"])
143-
chrome_options.add_experimental_option("useAutomationExtension", False)
143+
if servername == "localhost" or servername == "127.0.0.1":
144+
chrome_options.add_experimental_option("useAutomationExtension", False)
144145
if mobile_emulator:
145146
emulator_settings = {}
146147
device_metrics = {}
@@ -359,7 +360,7 @@ def get_driver(browser_name, headless=False, use_grid=False,
359360
device_width, device_height, device_pixel_ratio)
360361
else:
361362
return get_local_driver(
362-
browser_name, headless,
363+
browser_name, headless, servername,
363364
proxy_string, proxy_auth, proxy_user, proxy_pass, user_agent,
364365
disable_csp, enable_sync, user_data_dir,
365366
extension_zip, extension_dir, mobile_emulator,
@@ -381,8 +382,8 @@ def get_remote_driver(
381382
chrome_options = _set_chrome_options(
382383
downloads_path, headless, proxy_string, proxy_auth,
383384
proxy_user, proxy_pass, user_agent, disable_csp, enable_sync,
384-
user_data_dir, extension_zip, extension_dir, mobile_emulator,
385-
device_width, device_height, device_pixel_ratio)
385+
user_data_dir, extension_zip, extension_dir, servername,
386+
mobile_emulator, device_width, device_height, device_pixel_ratio)
386387
capabilities = chrome_options.to_capabilities()
387388
for key in desired_caps.keys():
388389
capabilities[key] = desired_caps[key]
@@ -489,7 +490,7 @@ def get_remote_driver(
489490

490491

491492
def get_local_driver(
492-
browser_name, headless,
493+
browser_name, headless, servername,
493494
proxy_string, proxy_auth, proxy_user, proxy_pass, user_agent,
494495
disable_csp, enable_sync, user_data_dir,
495496
extension_zip, extension_dir,
@@ -563,7 +564,7 @@ def get_local_driver(
563564
downloads_path, headless,
564565
proxy_string, proxy_auth, proxy_user, proxy_pass,
565566
user_agent, disable_csp, enable_sync, user_data_dir,
566-
extension_zip, extension_dir, mobile_emulator,
567+
extension_zip, extension_dir, servername, mobile_emulator,
567568
device_width, device_height, device_pixel_ratio)
568569
return webdriver.Chrome(executable_path=LOCAL_EDGEDRIVER,
569570
options=chrome_options)
@@ -588,7 +589,7 @@ def get_local_driver(
588589
downloads_path, headless,
589590
proxy_string, proxy_auth, proxy_user, proxy_pass,
590591
user_agent, disable_csp, enable_sync, user_data_dir,
591-
extension_zip, extension_dir, mobile_emulator,
592+
extension_zip, extension_dir, servername, mobile_emulator,
592593
device_width, device_height, device_pixel_ratio)
593594
if LOCAL_CHROMEDRIVER and os.path.exists(LOCAL_CHROMEDRIVER):
594595
make_driver_executable_if_not(LOCAL_CHROMEDRIVER)

0 commit comments

Comments
 (0)