Skip to content

Commit 14607a0

Browse files
committed
Save time by holding off on some imports until used later
1 parent 6e594a4 commit 14607a0

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,12 @@ def test_anything(self):
3333
import unittest
3434
import uuid
3535
from bs4 import BeautifulSoup
36-
from pyvirtualdisplay import Display
3736
from seleniumbase.common import decorators
38-
from seleniumbase.config import ad_block_list
3937
from seleniumbase.config import settings
4038
from seleniumbase.core.application_manager import ApplicationManager
41-
from seleniumbase.core.s3_manager import S3LoggingBucket
4239
from seleniumbase.core.testcase_manager import ExecutionQueryPayload
4340
from seleniumbase.core.testcase_manager import TestcaseDataPayload
4441
from seleniumbase.core.testcase_manager import TestcaseManager
45-
from seleniumbase.core import browser_launcher
4642
from seleniumbase.core import download_helper
4743
from seleniumbase.core import log_helper
4844
from seleniumbase.fixtures import constants
@@ -1608,6 +1604,7 @@ def remove_elements(self, selector, by=By.CSS_SELECTOR):
16081604
self.safe_execute_script(remove_script)
16091605

16101606
def ad_block(self):
1607+
from seleniumbase.config import ad_block_list
16111608
for css_selector in ad_block_list.AD_BLOCK_LIST:
16121609
css_selector = re.escape(css_selector)
16131610
script = ("""var $elements = document.querySelectorAll('%s');
@@ -2251,6 +2248,8 @@ def get_new_driver(self, browser=None, headless=None,
22512248
if browser_name not in valid_browsers:
22522249
raise Exception("Browser: {%s} is not a valid browser option. "
22532250
"Valid options = {%s}" % (browser, valid_browsers))
2251+
# Launch a web browser
2252+
from seleniumbase.core import browser_launcher
22542253
new_driver = browser_launcher.get_driver(browser_name=browser_name,
22552254
headless=headless,
22562255
use_grid=use_grid,
@@ -2792,6 +2791,7 @@ def setUp(self):
27922791
self.testcase_manager.insert_testcase_data(data_payload)
27932792
self.case_start_time = int(time.time() * 1000)
27942793
if self.headless:
2794+
from pyvirtualdisplay import Display
27952795
self.display = Display(visible=0, size=(1920, 1200))
27962796
self.display.start()
27972797
self.headless_active = True
@@ -2965,7 +2965,8 @@ def tearDown(self):
29652965
self.testcase_manager.update_execution_data(
29662966
self.execution_guid, runtime)
29672967
if self.with_s3_logging and has_exception:
2968-
""" After each testcase, upload logs to the S3 bucket. """
2968+
""" If enabled, upload logs to S3 during test exceptions. """
2969+
from seleniumbase.core.s3_manager import S3LoggingBucket
29692970
s3_bucket = S3LoggingBucket()
29702971
guid = str(uuid.uuid4().hex)
29712972
path = "%s/%s" % (self.log_path, test_id)

0 commit comments

Comments
 (0)