Merge pull request #1001 from seleniumbase/recorder-downloads

Recorder Mode updates for file downloads, classes, and form submissions

Author: mdmintz

README.md

@@ -6,7 +6,7 @@
 <link rel="icon" href="https://seleniumbase.io/img/logo6.png" />
 
 <h2 align="center"><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.io/cdn/img/sb_banner_t.png" alt="SeleniumBase" title="SeleniumBase" width="530" /></a></h2>
-<h4 align="center">Create web and mobile tests faster.</h4>
+<h4 align="center">Everything you need for web testing.</h4>
 <p align="center"><a href="https://github.com/seleniumbase/SeleniumBase/releases">
 <img src="https://img.shields.io/github/v/release/seleniumbase/SeleniumBase.svg?color=2277EE" alt="Latest Release on GitHub" /></a> <a href="https://pypi.org/project/seleniumbase/">
 <img src="https://img.shields.io/pypi/v/seleniumbase.svg?color=00a0e0" alt="Latest Release on PyPI" /></a> <a href="https://pepy.tech/project/seleniumbase">
@@ -16,7 +16,7 @@
 <p align="center"><a href="https://github.com/seleniumbase/SeleniumBase/actions">
 <img src="https://github.com/seleniumbase/SeleniumBase/workflows/CI%20build/badge.svg" alt="SeleniumBase GitHub Actions" /></a> <a href="https://dev.azure.com/seleniumbase/seleniumbase/_build/latest?definitionId=1&branchName=master"> <img src="https://dev.azure.com/seleniumbase/seleniumbase/_apis/build/status/seleniumbase.SeleniumBase?branchName=master" alt="SeleniumBase Azure Pipelines" /></a> <a href="https://gitter.im/seleniumbase/SeleniumBase">
 <img src="https://badges.gitter.im/seleniumbase/SeleniumBase.svg" alt="SeleniumBase" /></a> <a href="https://seleniumbase.io">
-<img src="https://img.shields.io/badge/docs-%20seleniumbase.io-22BBAA.svg" alt="SeleniumBase.io Docs" /></a></p>
+<img src="https://img.shields.io/badge/docs-%20📓📖📚-11BBCC.svg" alt="SeleniumBase.io Docs" title="SeleniumBase.io Docs" /></a></p>
 
 <p align="center">SeleniumBase is a complete framework for browser automation and testing with <a href="https://docs.pytest.org/en/latest/index.html">pytest</a>.<br />The API simplifies <a href="https://www.selenium.dev/documentation/">Selenium</a>'s out-of-the-box API, leading to cleaner, maintainable code. <br />Includes advanced features such as a <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/examples/example_logs/ReadMe.md">Dashboard</a>, a <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/recorder_mode.md">Recorder</a>, and <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/js_package_manager.md">JS code generators</a>.</p>
 

help_docs/recorder_mode.md

@@ -78,6 +78,8 @@ class RecorderTest(BaseCase):
 
 <p>🔴 SeleniumBase <code>1.66.8</code> generates better selectors in Recorder Mode and improves the algorithm for converting recorded actions into SeleniumBase code.</p>
 
+<p>🔴 SeleniumBase <code>1.66.9</code> allows the Recorder to record methods related to file downloads. It also updates how the Recorder handles class-parsing and form submissions.</p>
+
 --------
 
 <div>To learn more about SeleniumBase, check out the Docs Site:</div>

seleniumbase/__version__.py

@@ -1,2 +1,2 @@
 # seleniumbase package
-__version__ = "1.66.8"
+__version__ = "1.66.9"

seleniumbase/extensions/recorder.zip

@@ -3350,9 +3350,11 @@ def __process_recorded_actions(self):
         ext_actions.append("hi_li")
         ext_actions.append("as_lt")
         ext_actions.append("as_ti")
+        ext_actions.append("as_df")
+        ext_actions.append("do_fi")
+        ext_actions.append("as_at")
         ext_actions.append("as_te")
         ext_actions.append("as_et")
-        ext_actions.append("as_at")
         ext_actions.append("sw_fr")
         ext_actions.append("sw_dc")
         ext_actions.append("s_c_f")
@@ -3539,6 +3541,22 @@ def __process_recorded_actions(self):
                     sb_actions.append('self.%s("%s")' % (method, action[1]))
                 else:
                     sb_actions.append("self.%s('%s')" % (method, action[1]))
+            elif action[0] == "as_df":
+                method = "assert_downloaded_file"
+                if '"' not in action[1]:
+                    sb_actions.append('self.%s("%s")' % (method, action[1]))
+                else:
+                    sb_actions.append("self.%s('%s')" % (method, action[1]))
+            elif action[0] == "do_fi":
+                method = "download_file"
+                file_url = action[1][0]
+                dest = action[1][1]
+                if not dest:
+                    sb_actions.append('self.%s("%s")' % (
+                        method, file_url))
+                else:
+                    sb_actions.append('self.%s("%s", "%s")' % (
+                        method, file_url, dest))
             elif action[0] == "as_at":
                 method = "assert_attribute"
                 if ('"' not in action[1][0]) and action[1][2]:
@@ -4608,6 +4626,16 @@ def download_file(self, file_url, destination_folder=None):
         if not os.path.exists(destination_folder):
             os.makedirs(destination_folder)
         page_utils._download_file_to(file_url, destination_folder)
+        if self.recorder_mode:
+            url = self.get_current_url()
+            if url and len(url) > 0:
+                if ("http:") in url or ("https:") in url or ("file:") in url:
+                    if self.get_session_storage_item("pause_recorder") == "no":
+                        time_stamp = self.execute_script("return Date.now();")
+                        origin = self.get_origin()
+                        url_dest = [file_url, destination_folder]
+                        action = ["do_fi", url_dest, origin, time_stamp]
+                        self.__extra_actions.append(action)
 
     def save_file_as(self, file_url, new_file_name, destination_folder=None):
         """Similar to self.download_file(), except that you get to rename the
@@ -4776,6 +4804,15 @@ def assert_downloaded_file(self, file, timeout=None, browser=False):
                 % (file, self.get_downloads_folder(), timeout)
             )
             page_actions.timeout_exception("NoSuchFileException", message)
+        if self.recorder_mode:
+            url = self.get_current_url()
+            if url and len(url) > 0:
+                if ("http:") in url or ("https:") in url or ("file:") in url:
+                    if self.get_session_storage_item("pause_recorder") == "no":
+                        time_stamp = self.execute_script("return Date.now();")
+                        origin = self.get_origin()
+                        action = ["as_df", file, origin, time_stamp]
+                        self.__extra_actions.append(action)
         if self.demo_mode:
             messenger_post = "ASSERT DOWNLOADED FILE: [%s]" % file
             try:

seleniumbase/fixtures/base_case.py

@@ -155,19 +155,12 @@
     num_by_attr = [];
     child_count_by_attr = [];
     for (var i = 0; i < non_id_attributes.length; i++) {
-        if (non_id_attributes[i] == 'class' && el.hasAttribute('class')) {
-            class_name = el.getAttribute('class');
-            if (class_name.length > 0 && !class_name.includes(' ') &&
-                class_name.includes('-'))
-            {
-                selector_by_class = tag_name + '.' + class_name;
-                all_by_class = document.querySelectorAll(selector_by_class);
-                if (all_by_class.length == 1)
-                    return selector_by_class;
-            }
-            continue;
+        selector_by_attr[i] = null;
+        if (non_id_attributes[i] == 'class')
+            selector_by_attr[i] = selector_by_class;
+        else {
+            selector_by_attr[i] = cssPathByAttribute(el, non_id_attributes[i]);
         }
-        selector_by_attr[i] = cssPathByAttribute(el, non_id_attributes[i]);
         all_by_attr[i] = document.querySelectorAll(selector_by_attr[i]);
         num_by_attr[i] = all_by_attr[i].length;
         if (!selector_by_attr[i].includes(child_sep) &&
@@ -646,9 +639,7 @@
         if (ra_len > 0 && event.key.toLowerCase() === 'enter' &&
             document.recorded_actions[ra_len-1][0] === 'input' &&
             document.recorded_actions[ra_len-1][1] === selector &&
-            !document.recorded_actions[ra_len-1][2].endsWith('\n') &&
-            document.recorded_actions[ra_len-1][2].length > 0 &&
-            element.value.length == 0)
+            !document.recorded_actions[ra_len-1][2].endsWith('\n'))
         {
             s_text = document.recorded_actions[ra_len-1][2] + '\n';
             document.recorded_actions.pop();