Skip to content

Commit 1c31605

Browse files
authored
Merge pull request #952 from seleniumbase/fix-issue-with-contains-selector-and-demo-mode
Fix issue with the ":contains()" selector and Demo Mode
2 parents 67f6293 + e358751 commit 1c31605

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

examples/test_contains_selector.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44
class ContainsSelectorTests(BaseCase):
55
def test_contains_selector(self):
66
self.open("https://xkcd.com/2207/")
7-
self.assert_text("Math Work", "#ctitle")
7+
self.assert_element('div.box div:contains("Math Work")')
88
self.click('a:contains("Next")')
9-
self.assert_text("Drone Fishing", "#ctitle")
9+
self.assert_element('div div:contains("Drone Fishing")')

seleniumbase/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# seleniumbase package
2-
__version__ = "1.63.18"
2+
__version__ = "1.63.19"

seleniumbase/fixtures/base_case.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6984,7 +6984,9 @@ def assert_element(self, selector, by=By.CSS_SELECTOR, timeout=None):
69846984
return True
69856985
self.wait_for_element_visible(selector, by=by, timeout=timeout)
69866986
if self.demo_mode:
6987-
selector, by = self.__recalculate_selector(selector, by)
6987+
selector, by = self.__recalculate_selector(
6988+
selector, by, xp_ok=False
6989+
)
69886990
a_t = "ASSERT"
69896991
if self._language != "English":
69906992
from seleniumbase.fixtures.words import SD
@@ -8279,7 +8281,7 @@ def __slow_scroll_to_element(self, element):
82798281
def __highlight_with_assert_success(
82808282
self, message, selector, by=By.CSS_SELECTOR
82818283
):
8282-
selector, by = self.__recalculate_selector(selector, by)
8284+
selector, by = self.__recalculate_selector(selector, by, xp_ok=False)
82838285
element = self.wait_for_element_visible(
82848286
selector, by=by, timeout=settings.SMALL_TIMEOUT
82858287
)

0 commit comments

Comments
 (0)