Skip to content

Commit 2ef6788

Browse files
authored
Merge pull request #333 from seleniumbase/update-default-chrome-options
Update default Chrome options
2 parents e1cebd0 + ff5bd4e commit 2ef6788

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ With Python installed and on your System PATH, you can get the latest ``pip`` wi
2121
python -m easy_install -U pip
2222
```
2323

24-
### <img src="https://cdn2.hubspot.net/hubfs/100006/images/super_square_logo_3a.png" title="SeleniumBase" height="32"> Setup a Virtual Environment (optional):
24+
### <img src="https://cdn2.hubspot.net/hubfs/100006/images/super_square_logo_3a.png" title="SeleniumBase" height="32"> Setup a Virtual Environment: (Optional)
2525

26-
Optionally, you may want to use a **[Python Virtual Environment](https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/virtualenv_instructions.md)** to isolate Python dependencies between projects.
26+
You may want to use a **[Python Virtual Environment](https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/virtualenv_instructions.md)** to isolate Python dependencies between projects. (The official virtualenv tutorial can be found **[here](https://packaging.python.org/guides/installing-using-pip-and-virtual-environments/)**.)
2727

2828
### <img src="https://cdn2.hubspot.net/hubfs/100006/images/super_square_logo_3a.png" title="SeleniumBase" height="32"> Install ``seleniumbase``: [<img src="https://img.shields.io/badge/pypi-seleniumbase-22AAEE.svg" alt="pypi" />](https://pypi.python.org/pypi/seleniumbase)
2929
```

seleniumbase/core/browser_launcher.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ def _set_chrome_options(
106106
}
107107
}
108108
chrome_options.add_experimental_option("prefs", prefs)
109-
if headless:
110-
chrome_options.add_experimental_option("w3c", False)
111109
chrome_options.add_argument("--test-type")
112110
chrome_options.add_argument("--log-level=3")
113111
chrome_options.add_argument("--no-first-run")
@@ -141,8 +139,8 @@ def _set_chrome_options(
141139
chrome_options.add_argument("--headless")
142140
chrome_options.add_argument("--disable-gpu")
143141
chrome_options.add_argument("--no-sandbox")
144-
chrome_options.add_argument("--disable-setuid-sandbox")
145-
chrome_options.add_argument("--disable-dev-shm-usage")
142+
if "linux" in PLATFORM:
143+
chrome_options.add_argument("--disable-dev-shm-usage")
146144
return chrome_options
147145

148146

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
setup(
1919
name='seleniumbase',
20-
version='1.23.14',
20+
version='1.23.15',
2121
description='Reliable Browser Automation & Testing Framework',
2222
long_description=long_description,
2323
long_description_content_type='text/markdown',

0 commit comments

Comments
 (0)