Skip to content

Commit 305a726

Browse files
committed
Standardize default starting widths across browsers
1 parent a8ac8f2 commit 305a726

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1856,8 +1856,17 @@ def get_new_driver(self, browser=None, headless=None,
18561856
except Exception:
18571857
pass # Keep existing browser resolution
18581858
elif self.browser == 'firefox':
1859-
pass # No changes
1859+
width = settings.CHROME_START_WIDTH
1860+
try:
1861+
if self.maximize_option:
1862+
self.driver.maximize_window()
1863+
else:
1864+
self.driver.set_window_size(width, 720)
1865+
self.wait_for_ready_state_complete()
1866+
except Exception:
1867+
pass # Keep existing browser resolution
18601868
elif self.browser == 'safari':
1869+
width = settings.CHROME_START_WIDTH
18611870
if self.maximize_option:
18621871
try:
18631872
self.driver.maximize_window()
@@ -1866,10 +1875,11 @@ def get_new_driver(self, browser=None, headless=None,
18661875
pass # Keep existing browser resolution
18671876
else:
18681877
try:
1869-
self.driver.set_window_rect(10, 30, 945, 630)
1878+
self.driver.set_window_rect(10, 30, width, 630)
18701879
except Exception:
18711880
pass
18721881
elif self.browser == 'opera':
1882+
width = settings.CHROME_START_WIDTH
18731883
if self.maximize_option:
18741884
try:
18751885
self.driver.maximize_window()
@@ -1878,7 +1888,7 @@ def get_new_driver(self, browser=None, headless=None,
18781888
pass # Keep existing browser resolution
18791889
else:
18801890
try:
1881-
self.driver.set_window_rect(10, 30, 1150, 700)
1891+
self.driver.set_window_rect(10, 30, width, 700)
18821892
except Exception:
18831893
pass
18841894
if self.start_page and len(self.start_page) >= 4:

0 commit comments

Comments
 (0)