Refactoring and better error-handling

Author: mdmintz

seleniumbase/core/report_helper.py

@@ -49,8 +49,9 @@ def process_failures(test, test_count, browser_type, duration):
     bad_page_image = "failure_%s.png" % test_count
     bad_page_data = "failure_%s.txt" % test_count
     screenshot_path = "%s/%s" % (LATEST_REPORT_DIR, bad_page_image)
-    with open(screenshot_path, "wb") as file:
-        file.write(test._last_page_screenshot)
+    if hasattr(test, "_last_page_screenshot"):
+        with open(screenshot_path, "wb") as file:
+            file.write(test._last_page_screenshot)
     page_actions.save_test_failure_data(
         test.driver, bad_page_data, browser_type, folder=LATEST_REPORT_DIR
     )
@@ -69,6 +70,8 @@ def process_failures(test, test_count, browser_type, duration):
             exc_message = sys.last_value
         except Exception:
             exc_message = "(Unknown Exception)"
+    if not hasattr(test, "_last_page_url"):
+        test._last_page_url = "about:blank"
     return '"%s","%s","%s","%s","%s","%s","%s","%s","%s","%s"' % (
         test_count,
         "FAILED!",

seleniumbase/fixtures/base_case.py

@@ -5834,7 +5834,7 @@ def skip(self, reason=""):
                 self.__passed_then_skipped = True
             self.__will_be_skipped = True
             sb_config._results[test_id] = "Skipped"
-        if self.with_db_reporting:
+        if hasattr(self, "with_db_reporting") and self.with_db_reporting:
             if self.is_pytest:
                 self.__skip_reason = reason
             else:

seleniumbase/fixtures/page_actions.py

@@ -124,13 +124,12 @@ def is_attribute_present(
         element = driver.find_element(by=by, value=selector)
         found_value = element.get_attribute(attribute)
         if found_value is None:
-            raise Exception()
-
+            return False
         if value is not None:
             if found_value == value:
                 return True
             else:
-                raise Exception()
+                return False
         else:
             return True
     except Exception: