Improve Shadow-DOM compatibility

Author: mdmintz

seleniumbase/fixtures/base_case.py

@@ -5895,7 +5895,9 @@ def skip(self, reason=""):
 
     # Shadow DOM / Shadow-root methods
 
-    def __get_shadow_element(self, selector, timeout=None):
+    def __get_shadow_element(
+        self, selector, timeout=None, must_be_visible=False
+    ):
         self.wait_for_ready_state_complete()
         if timeout is None:
             timeout = settings.SMALL_TIMEOUT
@@ -5911,6 +5913,7 @@ def __get_shadow_element(self, selector, timeout=None):
         selectors = selector.split("::shadow ")
         element = self.get_element(selectors[0])
         selector_chain = selectors[0]
+        is_present = False
         for selector_part in selectors[1:]:
             shadow_root = None
             if (
@@ -5997,6 +6000,11 @@ def __get_shadow_element(self, selector, timeout=None):
                             try:
                                 element = shadow_root.find_element(
                                     By.CSS_SELECTOR, value=selector_part)
+                                is_present = True
+                                if must_be_visible:
+                                    if not element.is_displayed():
+                                        raise Exception(
+                                            "Shadow Root element not visible!")
                                 found = True
                                 break
                             except Exception:
@@ -6005,6 +6013,10 @@ def __get_shadow_element(self, selector, timeout=None):
                         if not found:
                             element = shadow_root.find_element(
                                 By.CSS_SELECTOR, value=selector_part)
+                            is_present = True
+                            if must_be_visible and not element.is_displayed():
+                                raise Exception(
+                                    "Shadow Root element not visible!")
                 else:
                     element = page_actions.wait_for_element_present(
                         shadow_root,
@@ -6013,11 +6025,16 @@ def __get_shadow_element(self, selector, timeout=None):
                         timeout=timeout,
                     )
             except Exception:
+                error = "not present"
+                the_exception = "NoSuchElementException"
+                if must_be_visible and is_present:
+                    error = "not visible"
+                    the_exception = "ElementNotVisibleException"
                 msg = (
-                    "Shadow DOM Element {%s} was not present after %s seconds!"
-                    % (selector_chain, timeout)
+                    "Shadow DOM Element {%s} was %s after %s seconds!"
+                    % (selector_chain, error, timeout)
                 )
-                page_actions.timeout_exception("NoSuchElementException", msg)
+                page_actions.timeout_exception(the_exception, msg)
         return element
 
     def __fail_if_invalid_shadow_selector_usage(self, selector):
@@ -6035,11 +6052,15 @@ def __is_shadow_selector(self, selector):
         return False
 
     def __shadow_click(self, selector, timeout):
-        element = self.__get_shadow_element(selector, timeout=timeout)
+        element = self.__get_shadow_element(
+            selector, timeout=timeout, must_be_visible=True
+        )
         element.click()
 
     def __shadow_type(self, selector, text, timeout, clear_first=True):
-        element = self.__get_shadow_element(selector, timeout=timeout)
+        element = self.__get_shadow_element(
+            selector, timeout=timeout, must_be_visible=True
+        )
         if clear_first:
             try:
                 element.clear()
@@ -6060,7 +6081,9 @@ def __shadow_type(self, selector, text, timeout, clear_first=True):
                 self.wait_for_ready_state_complete()
 
     def __shadow_clear(self, selector, timeout):
-        element = self.__get_shadow_element(selector, timeout=timeout)
+        element = self.__get_shadow_element(
+            selector, timeout=timeout, must_be_visible=True
+        )
         try:
             element.clear()
             backspaces = Keys.BACK_SPACE * 42  # Autofill Defense
@@ -6069,8 +6092,13 @@ def __shadow_clear(self, selector, timeout):
             pass
 
     def __get_shadow_text(self, selector, timeout):
-        element = self.__get_shadow_element(selector, timeout=timeout)
-        return element.text
+        element = self.__get_shadow_element(
+            selector, timeout=timeout, must_be_visible=True
+        )
+        element_text = element.text
+        if self.browser == "safari":
+            element_text = element.get_attribute("innerText")
+        return element_text
 
     def __get_shadow_attribute(self, selector, attribute, timeout):
         element = self.__get_shadow_element(selector, timeout=timeout)
@@ -6248,10 +6276,9 @@ def __wait_for_shadow_element_present(self, selector, timeout):
         return element
 
     def __wait_for_shadow_element_visible(self, selector, timeout):
-        element = self.__get_shadow_element(selector, timeout=timeout)
-        if not element.is_displayed():
-            msg = "Shadow DOM Element {%s} was not visible!" % selector
-            page_actions.timeout_exception("NoSuchElementException", msg)
+        element = self.__get_shadow_element(
+            selector, timeout=timeout, must_be_visible=True
+        )
         return element
 
     def __wait_for_shadow_attribute_present(