Skip to content

Commit 3d660a5

Browse files
committed
Make methods consistent between different parsers
1 parent 3a136d2 commit 3d660a5

File tree

2 files changed

+92
-91
lines changed

2 files changed

+92
-91
lines changed

seleniumbase/plugins/base_plugin.py

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ class Base(Plugin):
3838

3939
def options(self, parser, env):
4040
super().options(parser, env=env)
41-
parser.add_option(
41+
parser.addoption = parser.add_option # Reuse name from pytest parser
42+
parser.addoption(
4243
"--env",
4344
action="store",
4445
dest="environment",
@@ -63,38 +64,38 @@ def options(self, parser, env):
6364
help="""This option sets a test env from a list of choices.
6465
Access using "self.env" or "self.environment".""",
6566
)
66-
parser.add_option(
67+
parser.addoption(
6768
"--account",
6869
dest="account",
6970
default=None,
7071
help="""This option sets a test account string.
7172
In tests, use "self.account" to get the value.""",
7273
)
73-
parser.add_option(
74+
parser.addoption(
7475
"--data",
7576
dest="data",
7677
default=None,
7778
help="Extra data to pass to tests from the command line.",
7879
)
79-
parser.add_option(
80+
parser.addoption(
8081
"--var1",
8182
dest="var1",
8283
default=None,
8384
help="Extra data to pass to tests from the command line.",
8485
)
85-
parser.add_option(
86+
parser.addoption(
8687
"--var2",
8788
dest="var2",
8889
default=None,
8990
help="Extra data to pass to tests from the command line.",
9091
)
91-
parser.add_option(
92+
parser.addoption(
9293
"--var3",
9394
dest="var3",
9495
default=None,
9596
help="Extra data to pass to tests from the command line.",
9697
)
97-
parser.add_option(
98+
parser.addoption(
9899
"--variables",
99100
dest="variables",
100101
default=None,
@@ -109,7 +110,7 @@ def options(self, parser, env):
109110
Access: self.variables["num"]
110111
----------------------------------------------""",
111112
)
112-
parser.add_option(
113+
parser.addoption(
113114
"--settings_file",
114115
"--settings-file",
115116
"--settings",
@@ -119,38 +120,38 @@ def options(self, parser, env):
119120
help="""The file that stores key/value pairs for overriding
120121
values in the SeleniumBase settings.py file.""",
121122
)
122-
parser.add_option(
123+
parser.addoption(
123124
"--log_path",
124125
"--log-path",
125126
dest="log_path",
126127
default="latest_logs/",
127128
help="""(DEPRECATED) - This field is NOT EDITABLE anymore.
128129
Log files are saved to the "latest_logs/" folder.""",
129130
)
130-
parser.add_option(
131+
parser.addoption(
131132
"--archive_logs",
132133
"--archive-logs",
133134
action="store_true",
134135
dest="archive_logs",
135136
default=False,
136137
help="Archive old log files instead of deleting them.",
137138
)
138-
parser.add_option(
139+
parser.addoption(
139140
"--archive_downloads",
140141
"--archive-downloads",
141142
action="store_true",
142143
dest="archive_downloads",
143144
default=False,
144145
help="Archive old downloads instead of deleting them.",
145146
)
146-
parser.add_option(
147+
parser.addoption(
147148
"--report",
148149
action="store_true",
149150
dest="report",
150151
default=False,
151152
help="Create a fancy report at the end of the test suite.",
152153
)
153-
parser.add_option(
154+
parser.addoption(
154155
"--show_report",
155156
"--show-report",
156157
action="store_true",
@@ -167,7 +168,7 @@ def options(self, parser, env):
167168
found_timeout_arg = True
168169
if found_processes_arg:
169170
print("* WARNING: Don't use multi-threading with nosetests! *")
170-
parser.add_option(
171+
parser.addoption(
171172
"--processes",
172173
dest="processes",
173174
default=0,
@@ -177,7 +178,7 @@ def options(self, parser, env):
177178
print("\n WARNING: Don't use --timeout=s from pytest-timeout!")
178179
print(" It's not thread-safe for WebDriver processes!")
179180
print(" Use --time-limit=s from SeleniumBase instead!\n")
180-
parser.add_option(
181+
parser.addoption(
181182
"--timeout",
182183
dest="timeout",
183184
default=0,

0 commit comments

Comments
 (0)