Ignore "javascript:" and "mailto:" links with assert_no_404_errors()

Author: mdmintz

seleniumbase/fixtures/base_case.py

@@ -1681,7 +1681,11 @@ def assert_link_status_code_is_not_404(self, link):
     def assert_no_404_errors(self, multithreaded=True):
         """ Assert no 404 errors from page links obtained from:
             "a"->"href", "img"->"src", "link"->"href", and "script"->"src". """
-        links = self.get_unique_links()
+        all_links = self.get_unique_links()
+        links = []
+        for link in all_links:
+            if "javascript:" not in link and "mailto:" not in link:
+                links.append(link)
         if multithreaded:
             from multiprocessing.dummy import Pool as ThreadPool
             pool = ThreadPool(10)
@@ -1690,12 +1694,10 @@ def assert_no_404_errors(self, multithreaded=True):
             pool.join()
         else:
             for link in links:
-                if "javascript:" not in link:  # Ignore links with JavaScript
-                    self.assert_link_status_code_is_not_404(link)
+                self.assert_link_status_code_is_not_404(link)
         if self.demo_mode:
             messenger_post = ("ASSERT NO 404 ERRORS")
-            js_utils.post_messenger_success_message(
-                self.driver, messenger_post, self.message_duration)
+            self.__highlight_with_assert_success(messenger_post, "html")
 
     def print_unique_links_with_status_codes(self):
         """ Finds all unique links in the html of the page source