Skip to content

Commit 468c0d1

Browse files
authored
Merge pull request #1177 from seleniumbase/update-methods-for-detecting-capabilities
Update code for extracting "capabilities" from the driver
2 parents 8ca67d9 + 485ecb8 commit 468c0d1

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

help_docs/ReadMe.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
<a href="https://seleniumbase.io/help_docs/translations/">🌏 Translate</a> |
3030
<a href="https://seleniumbase.io/examples/dialog_boxes/ReadMe/">🛂 DialogBoxes</a>
3131
<br />
32-
<a href="https://seleniumbase.io/help_docs/recorder_mode.md">🔴 Recorder</a> |
32+
<a href="https://seleniumbase.io/help_docs/recorder_mode/">🔴 Recorder</a> |
3333
<a href="https://github.com/seleniumbase/SeleniumBase/tree/master/integrations/node_js">🏃 NodeRunner</a>
3434
<br />
3535
<a href="https://seleniumbase.io/examples/presenter/ReadMe/">🎞️ Presenter</a> |

seleniumbase/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# seleniumbase package
2-
__version__ = "2.3.13"
2+
__version__ = "2.3.14"

seleniumbase/fixtures/base_case.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1858,13 +1858,13 @@ def hover_on_element(self, selector, by=By.CSS_SELECTOR):
18581858
try:
18591859
return page_actions.hover_on_element(self.driver, selector)
18601860
except WebDriverException as e:
1861-
driver_capabilities = self.driver.__dict__["capabilities"]
1861+
driver_capabilities = self.driver.capabilities
18621862
if "version" in driver_capabilities:
18631863
chrome_version = driver_capabilities["version"]
18641864
else:
18651865
chrome_version = driver_capabilities["browserVersion"]
18661866
major_chrome_version = chrome_version.split(".")[0]
1867-
chrome_dict = self.driver.__dict__["capabilities"]["chrome"]
1867+
chrome_dict = self.driver.capabilities["chrome"]
18681868
chromedriver_version = chrome_dict["chromedriverVersion"]
18691869
chromedriver_version = chromedriver_version.split(" ")[0]
18701870
major_chromedriver_version = chromedriver_version.split(".")[0]
@@ -10396,7 +10396,12 @@ def __get_major_browser_version(self):
1039610396
try:
1039710397
version = self.driver.__dict__["caps"]["browserVersion"]
1039810398
except Exception:
10399-
version = self.driver.__dict__["caps"]["version"]
10399+
try:
10400+
version = self.driver.__dict__["caps"]["version"]
10401+
except Exception:
10402+
version = str(
10403+
self.driver.__dict__["capabilities"]["version"]
10404+
)
1040010405
self.driver.__dict__["caps"]["browserVersion"] = version
1040110406
major_browser_version = version.split(".")[0]
1040210407
return major_browser_version

0 commit comments

Comments
 (0)