Merge pull request #992 from seleniumbase/recorder-mode-updates-and-more

mdmintz · web-flow · commit 4e973b7098b9 · 2021-09-29T03:35:38.000-04:00
Recorder Mode updates and more
diff --git a/README.md b/README.md
@@ -47,10 +47,12 @@
 </p>
 
 <p align="left">
-✅ Smart-waiting code prevents flaky tests.<br />
-✅ Can run on  <a href="https://seleniumbase.io/integrations/github/workflows/ReadMe/">GHA</a>, <a href="https://seleniumbase.io/integrations/google_cloud/ReadMe/">GCP</a>, <a href="https://seleniumbase.io/integrations/azure/jenkins/ReadMe/">Azure</a>, & <a href="https://seleniumbase.io/integrations/docker/ReadMe/">Docker</a>.<br />
+✅ Get set up in minutes. Deploy anywhere.<br />
+✅ Build reliable tests with a <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/method_summary.md">complete API</a>.<br />
+✅ Learn from 100s of real-world <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/examples/ReadMe.md">examples</a>.<br />
+✅ Includes <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/examples/example_logs/ReadMe.md">dashboards and reporting tools</a>.<br />
 ✅ Supports Chromium, Firefox, IE, & Safari.<br />
-✅ Includes <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/examples/example_logs/ReadMe.md">dashboards and reporting tools</a>.
+✅ Can run on  <a href="https://seleniumbase.io/integrations/github/workflows/ReadMe/">GHA</a>, <a href="https://seleniumbase.io/integrations/google_cloud/ReadMe/">GCP</a>, <a href="https://seleniumbase.io/integrations/azure/jenkins/ReadMe/">Azure</a>, & <a href="https://seleniumbase.io/integrations/docker/ReadMe/">Docker</a>.<br />
 </p>
 
 --------
diff --git a/docs/requirements.txt b/docs/requirements.txt
@@ -11,7 +11,7 @@ keyring==23.2.1;python_version>="3.6"
 pkginfo==1.7.1;python_version>="3.6"
 Jinja2==3.0.1;python_version>="3.6"
 click==8.0.1;python_version>="3.6"
-zipp==3.5.0;python_version>="3.6"
+zipp==3.5.1;python_version>="3.6"
 readme-renderer==29.0
 pymdown-extensions==8.2;python_version>="3.6"
 importlib-metadata==4.8.1;python_version>="3.6"
diff --git a/examples/ReadMe.md b/examples/ReadMe.md
@@ -7,9 +7,10 @@
 
 * <b>SeleniumBase</b> tests are run with <b>pytest</b>.
 * Chrome is the default browser if not specified.
-* Example tests are located in: <b>[SeleniumBase/examples/](https://github.com/seleniumbase/SeleniumBase/tree/master/examples)</b>.
-* During test failures, logs and screenshots from the latest test run are saved to the ``latest_logs/`` folder.
-* Tests can be structured using [17 unique syntax formats](https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/syntax_formats.md).
+* Tests are structured using [17 unique syntax formats](https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/syntax_formats.md).
+* Logs from test failures are saved to ``./latest_logs/``.
+* Tests can be run with [multiple command-line options](https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/customizing_test_runs.md).
+* Example tests are found in: **[SeleniumBase/examples/](https://github.com/seleniumbase/SeleniumBase/tree/master/examples)**.
 
 (NOTE: Some example tests fail on purpose to demonstrate [logging features](https://github.com/seleniumbase/SeleniumBase/blob/master/examples/example_logs/ReadMe.md).)
 
diff --git a/examples/test_hack_search.py b/examples/test_hack_search.py
@@ -12,18 +12,16 @@ def test_hack_search(self):
         self.assert_element('input[title="Search"]')
         self.set_attribute('[action="/search"]', "action", "//bing.com/search")
         self.set_attributes('[value="Google Search"]', "value", "Bing Search")
-        self.type('input[title="Search"]', "SeleniumBase GitHub")
+        self.type('input[title="Search"]', "SeleniumBase GitHub Docs Install")
         self.sleep(0.5)
         self.js_click('[value="Bing Search"]')
         self.highlight("h1.b_logo")
         help_docs_install_link = 'a[href*="seleniumbase.io/help_docs/install"]'
         if self.is_element_visible(help_docs_install_link):
             self.highlight_click(help_docs_install_link)
-            self.switch_to_newest_window()
             self.assert_text("Install SeleniumBase", "h1")
             self.click_link_text("GitHub branch")
         self.highlight_click('a[href*="github.com/seleniumbase/SeleniumBase"]')
-        self.switch_to_newest_window()
         self.assert_element('[href="/seleniumbase/SeleniumBase"]')
         self.assert_true("seleniumbase/SeleniumBase" in self.get_current_url())
         self.click('a[title="examples"]')
diff --git a/examples/translations/pytest.ini b/examples/translations/pytest.ini
@@ -18,7 +18,8 @@ python_files = test_*.py *_test.py *_tests.py *_suite.py *_test_*.py
 python_classes = Test* *Test* *Test *Tests *Suite
 python_functions = test_*
 
-# Here are the pytest markers used in the example tests:
+# Here are some common pytest markers:
+# (Some are used in the example tests.)
 # (pytest v4.5.0 and newer requires marker registration to prevent warnings.)
 # (Future versions of pytest may turn those marker warnings into errors.)
 markers =
@@ -32,7 +33,11 @@ markers =
     offline: custom marker
     develop: custom marker
     qa: custom marker
+    ci: custom marker
+    e2e: custom marker
     ready: custom marker
+    smoke: custom marker
+    deploy: custom marker
     active: custom marker
     master: custom marker
     release: custom marker
diff --git a/help_docs/js_package_manager.md b/help_docs/js_package_manager.md
@@ -1,4 +1,4 @@
-[<img src="https://seleniumbase.io/cdn/img/super_logo_sb.png" title="SeleniumBase" width="290">](https://github.com/seleniumbase/SeleniumBase/blob/master/README.md)
+[<img src="https://seleniumbase.io/cdn/img/sb_logo_10t.png" title="SeleniumBase" width="220">](https://github.com/seleniumbase/SeleniumBase/)
 
 <h2><img src="https://seleniumbase.io/img/logo6.png" title="SeleniumBase" width="32" /> JS Package Manager</h2>
 
@@ -90,6 +90,8 @@ def add_css_link(driver, css_link):
 
 --------
 
+[<img src="https://seleniumbase.io/cdn/img/super_logo_sb.png" title="SeleniumBase" width="220">](https://github.com/seleniumbase/SeleniumBase/)
+
 <div>To learn more about SeleniumBase, check out the Docs Site:</div>
 <a href="https://seleniumbase.io">
 <img src="https://img.shields.io/badge/docs-%20%20SeleniumBase.io-11BBDD.svg" alt="SeleniumBase.io Docs" /></a>
diff --git a/help_docs/method_summary.md b/help_docs/method_summary.md
@@ -224,9 +224,9 @@ self.switch_to_driver(driver)
 
 self.switch_to_default_driver()
 
-self.save_screenshot(name, folder=None)
+self.save_screenshot(name, folder=None, selector=None, by=By.CSS_SELECTOR)
 
-self.save_screenshot_to_logs(name=None)
+self.save_screenshot_to_logs(name=None, selector=None, by=By.CSS_SELECTOR)
 
 self.save_page_source(name, folder=None)
 
diff --git a/help_docs/recorder_mode.md b/help_docs/recorder_mode.md
@@ -2,11 +2,11 @@
 
 <h2><img src="https://seleniumbase.io/img/logo6.png" title="SeleniumBase" width="32" /> Recorder Mode</h2>
 
-🔴 SeleniumBase <b>Recorder Mode</b> gives you the power to create automation scripts from manual browser actions.<br>(<i>Only Chromium browsers such as Chrome and Edge are supported.</i>)
+🔴 <b>SeleniumBase Recorder Mode</b> lets you record & export browser actions into automation scripts.<br>
 
 <img src="https://seleniumbase.io/cdn/img/sb_recorder_notification.png" title="SeleniumBase" width="380">
 
-🔴 To activate Recorder Mode, add ``--recorder`` to your ``pytest`` run command when running an existing test: (Also add ``-s`` to allow breakpoints, unless you already have a ``pytest.ini`` file present with ``--capture=no`` in it.)
+🔴 To activate Recorder Mode, add ``--recorder`` to your ``pytest`` run command when running an existing test on Chrome or Edge. (Also add ``-s`` to allow breakpoints, unless you already have a ``pytest.ini`` file present with ``addopts = --capture=no`` in it.)
 
 ```bash
 pytest TEST_NAME.py --recorder -s
@@ -60,6 +60,8 @@ class RecorderTest(BaseCase):
 
 <p>🔴 SeleniumBase <code>1.66.3</code> improves the algorithm for generating efficient selectors. Additionally, single and double quotes in selectors will now be properly escaped with backslashes as needed.</p>
 
+<p>🔴 SeleniumBase <code>1.66.4</code> adds better error-handling when using The Recorder, as well as a few other improvements.</p>
+
 --------
 
 <div>To learn more about SeleniumBase, check out the Docs Site:</div>
diff --git a/requirements.txt b/requirements.txt
@@ -36,7 +36,7 @@ msedge-selenium-tools==3.141.3
 more-itertools==5.0.0;python_version<"3.5"
 more-itertools==8.10.0;python_version>="3.5"
 cssselect==1.1.0
-filelock==3.0.12
+filelock==3.1.0
 fasteners==0.16;python_version<"3.5"
 fasteners==0.16.3;python_version>="3.5"
 execnet==1.9.0
@@ -69,8 +69,6 @@ beautifulsoup4==4.10.0;python_version>="3.5"
 cryptography==2.9.2;python_version<"3.5"
 cryptography==3.2.1;python_version>="3.5" and python_version<"3.6"
 cryptography==3.4.8;python_version>="3.6"
-pyopenssl==19.1.0;python_version<"3.5"
-pyopenssl==20.0.1;python_version>="3.5"
 pygments==2.5.2;python_version<"3.5"
 pygments==2.10.0;python_version>="3.5"
 traitlets==4.3.3;python_version<"3.7"
diff --git a/seleniumbase/__version__.py b/seleniumbase/__version__.py
@@ -1,2 +1,2 @@
 # seleniumbase package
-__version__ = "1.66.3"
+__version__ = "1.66.4"
diff --git a/seleniumbase/config/ad_block_list.py b/seleniumbase/config/ad_block_list.py
@@ -69,7 +69,7 @@
     "[data-google-av-adk]",
     "[data-google-query-id]",
     '[data-ylk*="sponsored_cluster"]',
-    '[data-google-av-cxn*="pagead"]',
+    "[data-google-av-cxn]",
     "[data-ad-client]",
     "[data-ad-slot]",
     '[href*="doubleclick"]',
@@ -108,4 +108,5 @@
     'link[href*="/adservice."]',
     "section.dianomi-ad",
     "ytd-promoted-video-renderer",
+    "ytd-video-masthead-ad-v3-renderer",
 ]
diff --git a/seleniumbase/config/settings.py b/seleniumbase/config/settings.py
@@ -38,6 +38,15 @@
 HTML_REPORT = "report.html"
 RESULTS_TABLE = "results_table.csv"
 
+"""
+If True, switch to new tabs/windows automatically if a click opens a new one.
+(This switch only happens if the initial tab is still on same URL as before,
+which prevents a situation where a click opens up a new URL in the same tab,
+where a pop-up might open up a new tab on its own, leading to a double open.
+If False, the browser will stay on the current tab where the click happened.
+"""
+SWITCH_TO_NEW_TABS_ON_CLICK = True
+
 """
 This adds wait_for_ready_state_complete() after various browser actions.
 Setting this to True may improve reliability at the cost of speed.
diff --git a/seleniumbase/console_scripts/sb_install.py b/seleniumbase/console_scripts/sb_install.py
@@ -44,8 +44,8 @@
 DRIVER_DIR = os.path.dirname(os.path.realpath(drivers.__file__))
 LOCAL_PATH = "/usr/local/bin/"  # On Mac and Linux systems
 DEFAULT_CHROMEDRIVER_VERSION = "2.44"  # (Specify "latest" to get the latest)
-DEFAULT_GECKODRIVER_VERSION = "v0.29.1"
-DEFAULT_EDGEDRIVER_VERSION = "91.0.864.71"  # (Looks for LATEST_STABLE first)
+DEFAULT_GECKODRIVER_VERSION = "v0.30.0"
+DEFAULT_EDGEDRIVER_VERSION = "93.0.961.52"  # (Looks for LATEST_STABLE first)
 DEFAULT_OPERADRIVER_VERSION = "v.88.0.4324.104"
 
 
diff --git a/seleniumbase/core/browser_launcher.py b/seleniumbase/core/browser_launcher.py
@@ -399,10 +399,11 @@ def _set_chrome_options(
             )
         chrome_options.add_experimental_option("useAutomationExtension", False)
     if (settings.DISABLE_CSP_ON_CHROME or disable_csp) and not headless:
-        # Headless Chrome doesn't support extensions, which are required
-        # for disabling the Content Security Policy on Chrome
+        # Headless Chrome does not support extensions, which are required
+        # for disabling the Content Security Policy on Chrome.
         chrome_options = _add_chrome_disable_csp_extension(chrome_options)
     if ad_block_on and not headless:
+        # Headless Chrome does not support extensions.
         chrome_options = _add_chrome_ad_block_extension(chrome_options)
     if recorder_ext and not headless:
         chrome_options = _add_chrome_recorder_extension(chrome_options)
@@ -494,18 +495,9 @@ def _set_firefox_options(
     options.set_preference("extensions.update.autoUpdateDefault", False)
     options.set_preference("extensions.update.enabled", False)
     options.set_preference("extensions.update.silent", True)
-    options.set_preference(
-        "datareporting.healthreport.logging.consoleEnabled", False
-    )
     options.set_preference("datareporting.healthreport.service.enabled", False)
-    options.set_preference(
-        "datareporting.healthreport.service.firstRun", False
-    )
     options.set_preference("datareporting.healthreport.uploadEnabled", False)
     options.set_preference("datareporting.policy.dataSubmissionEnabled", False)
-    options.set_preference(
-        "datareporting.policy.dataSubmissionPolicyAccepted", False
-    )
     options.set_preference("toolkit.telemetry.unified", False)
     if proxy_string:
         socks_proxy = False
diff --git a/seleniumbase/fixtures/base_case.py b/seleniumbase/fixtures/base_case.py
diff --git a/seleniumbase/fixtures/page_actions.py b/seleniumbase/fixtures/page_actions.py
diff --git a/seleniumbase/plugins/pytest_plugin.py b/seleniumbase/plugins/pytest_plugin.py
diff --git a/seleniumbase/plugins/selenium_plugin.py b/seleniumbase/plugins/selenium_plugin.py
diff --git a/setup.py b/setup.py

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`# seleniumbase package`
`2`		`-__version__ = "1.66.3"`
	`2`	`+__version__ = "1.66.4"`