If a click opens a new tab, switch to it automatically

Author: mdmintz

seleniumbase/config/settings.py

@@ -38,6 +38,15 @@
 HTML_REPORT = "report.html"
 RESULTS_TABLE = "results_table.csv"
 
+"""
+If True, switch to new tabs/windows automatically if a click opens a new one.
+(This switch only happens if the initial tab is still on same URL as before,
+which prevents a situation where a click opens up a new URL in the same tab,
+where a pop-up might open up a new tab on its own, leading to a double open.
+If False, the browser will stay on the current tab where the click happened.
+"""
+SWITCH_TO_NEW_TABS_ON_CLICK = True
+
 """
 This adds wait_for_ready_state_complete() after various browser actions.
 Setting this to True may improve reliability at the cost of speed.

seleniumbase/fixtures/base_case.py

@@ -316,10 +316,18 @@ def click(
                         self.driver, selector, by, timeout=timeout
                     )
                     element.click()
-        if self.recorder_mode:
-            latest_window_count = len(self.driver.window_handles)
-            if latest_window_count > pre_window_count:
-                self.switch_to_newest_window()
+        latest_window_count = len(self.driver.window_handles)
+        if (
+            latest_window_count > pre_window_count
+            and (
+                self.recorder_mode
+                or (
+                    settings.SWITCH_TO_NEW_TABS_ON_CLICK
+                    and self.driver.current_url == pre_action_url
+                )
+            )
+        ):
+            self.switch_to_newest_window()
         if settings.WAIT_FOR_RSC_ON_CLICKS:
             self.wait_for_ready_state_complete()
         if self.demo_mode:
@@ -3721,6 +3729,20 @@ def js_click(
             else:
                 click_script = """jQuery('%s').click();""" % css_selector
                 self.safe_execute_script(click_script)
+        if self.recorder_mode and action:
+            self.__extra_actions.append(action)
+        latest_window_count = len(self.driver.window_handles)
+        if (
+            latest_window_count > pre_window_count
+            and (
+                self.recorder_mode
+                or (
+                    settings.SWITCH_TO_NEW_TABS_ON_CLICK
+                    and self.driver.current_url == pre_action_url
+                )
+            )
+        ):
+            self.switch_to_newest_window()
         self.wait_for_ready_state_complete()
         self.__demo_mode_pause_if_active()
 
@@ -9862,6 +9884,10 @@ def setUp(self, masterqa_mode=False):
             # Only filled when Recorder Mode is enabled
             sb_config._recorded_actions = {}
 
+        if not hasattr(settings, "SWITCH_TO_NEW_TABS_ON_CLICK"):
+            # If using an older settings file, set the new definitions manually
+            settings.SWITCH_TO_NEW_TABS_ON_CLICK = True
+
         # Parse the settings file
         if self.settings_file:
             from seleniumbase.core import settings_parser